[koha-commits] main Koha release repository branch master updated. v3.14.00-139-g6cf065d

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  6cf065da5e6ef431f266359aaa3737b85f330e93 (commit)
      from  4e64ea8870cca3715f838ae3b577cb05da2f7879 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6cf065da5e6ef431f266359aaa3737b85f330e93
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date:   Wed Dec 4 20:44:36 2013 -0300

    Bug 7934: generate separate PO files for help pages
    
    This patch modifies LangInstaller.pm to enable separation
    of translation for Staff UI and Staff Help files.
    
    It's a move that make sense, Help strings accounts for
    44% of total word count for Staff, and as stated on
    Comment #1, it could enable a different workflow on
    translation work.
    
    It's more a hack than an elegant solution, but it works.
    Feel free to suggest another approach.
    
    To test:
    
    We need to test complete functionality, i.e. create and update
    translation files and install translation, and verify that no
    string is missing.
    
    1) Before applying the patch, we need some data from staff file.
    Pick your language, say de_DE, and
    
    cd misc/translator/
    perl translate update de-DE
    msginit -i po/de-DE-i-staff-t-prog-v-3006000.po -o de-old.po --no-translator --no-wrap --locale=de_DE
    egrep ^msgid de-old.po | sort | tee s-old | wc -l > number-old
    
    We have the file s-old with all strings, and the number of strings on number-old
    
    2) Apply the patch
    
    3) New help file is called de-DE-staff-help.po, so create one
    cp'ing old staff on new help
    
    cp po/de-DE-i-staff-t-prog-v-3006000.po po/de-DE-staff-help.po
    
    4) Make a new update, and analize
    
    perl translate update de-DE
    msginit -i po/de-DE-i-staff-t-prog-v-3006000.po -o de-new.po --no-translator --no-wrap --locale=de_DE
    msginit -i po/de-DE-staff-help.po -o de-help.po --no-translator --no-wrap --locale=de_DE
    egrep ^msgid de-new.po | sort | tee s-new | wc -l > number-new
    egrep ^msgid de-help.po | sort | tee s-help | wc -l > number-help
    cat s-new s-help | sort | uniq | tee s-all | wc -l > number-all
    cat s-new s-help | sort | uniq -d | tee s-dup | wc -l > number-dup
    
    Ideally what we need to found is:
    
    diff s-old s-all = zero lines (old strings vs new strings)
    
    In my test I got one line, but it's a false positive (the string "• " is present on new staff)
    
    On numbers,
    
    number-old - number-new - nummber-help + number-dup = 0
    or
    number-old - number-all = 0
    
    (in my test again I have 1 as result, same string. Also there are 137
    repeated lines between new staff and help)
    
    All this tells me that all string to translate are preserved
    
    5) Install translation
    
    perl translate install de-DE
    
    Enable language on staff, and check that help files are translated
    
    6) Finally, create translation files
    
    rm po/de-DE-*
    perl translate create de-DE
    
    verify that all files are created. Tests of 4) can be repeated.
    
    7) Verify that no strings from help are present on staff UI file
    
    egrep help po/de-DE-i-staff-t-prog-v-3006000.po
    
    Only results came from help-top and bottom, and a few "help" on staff strings
    
    Signed-off-by: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Tested according to test plan. Checked various pages in OPAC,
    staff and intranet, translation was ok.
    Passes QA script and tests.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 misc/translator/LangInstaller.pm |   36 +++++++++++++++++++++++++++---------
 1 file changed, 27 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
main Koha release repository