[koha-commits] main Koha release repository branch 3.14.x updated. v3.14.00-57-ge266369

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.14.x has been updated
       via  e2663694a42609a0536de489c0bd67efae42afeb (commit)
       via  51f5a5f5702624dadce8811042dfadcc07a3b866 (commit)
      from  6e0985f7d85f3bc41cf78e76ff2db2a3b3245915 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e2663694a42609a0536de489c0bd67efae42afeb
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Mon Oct 21 12:13:17 2013 +0200

    Bug 11091: (follow-up) perltidy on serials/subscription-bib-search.pl
    
    Signed-off-by: David Noe <drnoe at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit fd22187914afe5c806a98ea6eda0b2d0b455ab36)
    Signed-off-by: Fridolin SOMERS <fridolin.somers at biblibre.com>

commit 51f5a5f5702624dadce8811042dfadcc07a3b866
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Mon Oct 21 11:54:16 2013 +0200

    Bug 11091: revamp search limit options for new subscription bib search form
    
    When creating a new subscription, you can click on "Search for Bilbio"
    to search into catalog.
    
    A popup opens with a text field for search terms and a combo-box to
    limit search. This combo-box uses the syspref AdvancedSearchTypes to
    know what list of values display.
    
    The bug is that the code acts as if AdvancedSearchTypes has always one
    value, but since Bug 7031, this syspref can have several values
    (item types, collection codes and locations).
    
    This patch removes the use of AdvancedSearchTypes syspref and defines
    search form with 2 limits: item types and collection codes (from
    authorised values CCODE).
    
    One or both of this information can be on biblio. [RM note: this isn't a
    true statement for the default configuration used by MARC21 libraries.]
    
    Searching by location seems to be useless because this information is always
    on item.  If CCODE authorised value does not exist or is empty, the collection
    code filter is not displayed.
    
    Test plan :
    - Check CCODE authorised value exists with some values
    - Choose a biblio indexed with both itemtype and ccode indexes
    - Go to Serials module and click on "New subscription"
    - In form, click on "Search for Biblio"
    => The popup "serials/subscription-bib-search.pl" appears with two limits
    - Enter a word of biblio title, select its item type and select its collection code
    - Click on "Search"
    => You get the biblio
    
    Signed-off-by: David Noe <drnoe at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    
    While I am not sure how useful the collection code is for most libraries, where this
    is an item level value, this fixes a broken feature and works as described.
    Passes all tests and QA script.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit e208386aaeaf31bd6f455077382ffd05b0b345b9)
    Signed-off-by: Fridolin SOMERS <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 .../en/modules/serials/subscription-bib-search.tt  |   55 +++--
 serials/subscription-bib-search.pl                 |  224 +++++++++-----------
 2 files changed, 137 insertions(+), 142 deletions(-)


hooks/post-receive
-- 
main Koha release repository