[koha-commits] main Koha release repository branch master updated. v3.14.00-156-g8ee6e42

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  8ee6e4290e2d1ca4fea53363b7ca3275cb0e6f58 (commit)
       via  5a3db23362eb076a2f6d5a87f87b29f4a436a14f (commit)
       via  f874eec0793f83c3c0f1461fecb878ca57ed701b (commit)
      from  0668dd7a8dbf2b34d8a93454bebf93dde44de38f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8ee6e4290e2d1ca4fea53363b7ca3275cb0e6f58
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Thu Dec 19 11:05:54 2013 +0100

    Bug 11279: (follow-up) remove unnecessary check on number of quotes
    
    It is not necessary to process the case where the number of quotes
    is just one, as int(rand(1)) will always produce 0, which is a valid
    offset.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 5a3db23362eb076a2f6d5a87f87b29f4a436a14f
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date:   Thu Dec 12 00:54:08 2013 +0100

    Bug 11279: Improve how a new quote of the day is selected
    
    If there is a gap in the id sequence for the quotes table, it
    is possible that no new quote will be selected. This will happen
    particularly when a lot of the older quotes with low ids have been
    deleted.
    
    This patch improves the selection of a new quote.
    
    To test:
    - Load sample quotes
    - Delete the first half of the quotes.
      Note: With 34 quotes, delete the quotes with ids from 1-17
    - Activate the QuoteOfTheDay system preference
    - Check if a quote is displayed in OPAC
    - Reload the page a few times, no quote should be displayed
      Note: make sure you don't have a quote with the current
      date in your quotes table before running those tests
    - Run 'perl t/db_dependent/Koha.t'
      Note: requires sample quotes!
    - Apply patch
    - Reload the OPAC start page
    - Verify a quote was now picked
    - Run 'perl t/db/dependent/Koha.t' again - all tests should still pass
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    
    Patch modified to use "LIMIT 1 OFFSET ?" rather than "LIMIT ?, 1"; the
    latter construction does not work in PostgreSQL.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit f874eec0793f83c3c0f1461fecb878ca57ed701b
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date:   Thu Dec 12 20:50:52 2013 +0100

    Bug 11279: regression test for picking random quote
    
    This patch adds new tests based on the db_dependent tests in
    t/db_dependent/Koha.t for GetDailyQuote().
    
    Tests run on an empty database and don't require Test::Deep.
    
    Tests will fail before applying the patch for 11297, but will
    pass after applying the patch.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Koha.pm                          |   23 +++++------
 t/db_dependent/Koha/GetDailyQuote.t |   77 +++++++++++++++++++++++++++++++++++
 2 files changed, 87 insertions(+), 13 deletions(-)
 create mode 100644 t/db_dependent/Koha/GetDailyQuote.t


hooks/post-receive
-- 
main Koha release repository