[koha-commits] main Koha release repository branch 3.8.x updated. v3.08.13-163-gd0ddbfd

Fri Dec 20 14:46:22 CET 2013

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.8.x has been updated
       via  d0ddbfd0f729466974e1d9ac8048d35101f77866 (commit)
       via  484aae44186eb9c410e363648f2b99da63d66901 (commit)
       via  b25014116e3dc11472ab47fd3c74b1dcabea613c (commit)
       via  ec0e086fde1895990750f8a1f9657996567e3fee (commit)
       via  af1b555438f29c301e09cf0776da1811ec0ba394 (commit)
       via  78474a0e99021d3d9e3a1bdc1a3cc3b59ab37b86 (commit)
      from  346c589fcf811a021ee49f402a8a2f508fb2240e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d0ddbfd0f729466974e1d9ac8048d35101f77866
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Tue Aug 13 14:55:32 2013 +0200

    Bug 10718: fix items with no checkouts report

    Bug 8124 has commented the option to download results items with no
    checkouts report into a file.  But the perl code of this page uses
    the export into a file has default behavior since the input "output"
    is no more present.  The consequence is that there are never results
    in page.

    This patch removes the code concerning file output from template and perl.
    Such a feature exists in guided reports.

    Test plan :
    Play with cgi-bin/koha/reports/catalogue_out.pl form and see if you get results

    Bug 10718 - select user branch as default

    In cgi-bin/koha/reports/catalogue_out.pl report, select in library filter the user logged-in.

    Test plan :
    - Log into intranet with a normal user
    - Got to "Items with no checkouts" reports
    => Your branch is selected
    - Run report
    => You see "Filtered on : Branch = <your branch>"
    - Come back to report
    - Select "Any library"
    - Run report
    => You do not see "Filtered on : Branch"

    Bug 10718 - items with no checkouts report permission is execute_reports

    This report only executes SQL to change reports/catalogue_out.pl permissions from all reports subpermissions to reports/execute_reports.

    Test plan :
    Test you can access and run this report with only execute_reports subpermission into reports permission.

    Bug 10718 - redefine limit input

    In reports/catalogue_out.pl form, the limit input is by defaut none.
    So by default the report queries all the catalogue.
    This may take a very long time (fall into timeout) and since now the results are displayed in page, the page may be huge.

    This patch modifies limit input to removes the "none" option.
    Also reduces the number of options (same options as guided reports results per page).

    Test plan:
    - Go to reports/catalogue_out.pl
    => first value "10" is selected
    - Launch report
    => You see "Filtered on: limit = 10"

    Bug 10718 - perltidy on reports/catalogue_out.pl

    Signed-off-by: Liz Rea <liz at catalyst.net.nz>
    Tested all of these things, all ok - squashed patch for neatness.

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.
    Fixed a tab in one of the comments.
    Improves script, but more work needed.

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit ec09fe092e302dfbaf8ddf2a26ab361be9ea915e)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit 4bc27151a1cb5a50825fc739e8ccf84aef913afb)
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    (cherry picked from commit 4bc27151a1cb5a50825fc739e8ccf84aef913afb)
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 485f871438d6fd70cd566e26766564275ad54134)

commit 484aae44186eb9c410e363648f2b99da63d66901
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Wed Jul 10 11:06:39 2013 +0200

    Bug 10564 - use OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl

    When using UNIMARC XSLT for OPAC detail page, if record has an 856$u,
    its content is displayed as a link. The syspref OPACURLOpenInNewWindow
    adds the option of opening in a new window (attribute target="_blank").

    856$u is also used in UNIMARC results XSLT but the use of
    OPACURLOpenInNewWindow syspref is missing. It exists for MARC21.

    This patch adds the use of OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl.

    Test plan :
    - In a UNIMARC catalog, enable XSLT for OPAC results page
    - Create a record with a link in 856$u and set second indicator to 0
    - Set OPACURLOpenInNewWindow syspref on
    - At OPAC, perform a search that contains the record
    => You should see the link : "Click here to access online"
    - click on it
    => You shoud get to a new window (or tab depending on your browser configuration)
    - Set OPACURLOpenInNewWindow syspref off
    - re-perform the search
    - click on the link
    => You shoud stay in same window

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

    Comment: Work as described, no koha-qa errors
    Tested following plan after applying patch

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    XSLT change only, works as described.
    To test: Catalog 856$u and $a, 2nd indicator = 0.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit bc240a908d0fbc50b099df04e61da9fbb55fab52)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit 815a7cb6b94455d4e0a0ea88f7cd0bcb8621cd6e)
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 9c4475ae343c31475512a28ffa834fbd5009de1f)

commit b25014116e3dc11472ab47fd3c74b1dcabea613c
Author: Janusz Kaczmarek <januszop at gmail.com>
Date:   Fri May 24 14:38:10 2013 +0300

    Bug 10331 - Little errors in unimarc_field_4XX.pl (punctuation)

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Comment: Work as described, no koha-qa errors

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Copying the test plan from the bug report:

    A.
    1) have $a active in one of the linking fields (like 461, 463, etc.).
    2) have a biblio record with the field 700 $a, $b, $f filled up
    3) go to cataloguing -> field 4XX of your choice, use the plugin to
      fetch data from biblio rec. mentioned in 2)
    4) see the punctuation in $a -- it will be wrong (no closing bracket)

    B.
    1) have $a active in one of the linking fields (like 461, 463, etc.).
    2) have a biblio record with the field 700 $a, $b, $c, $f filled up
    3) go to cataloguing -> field 4XX of your choice, use the plugin to
       fetch data from biblio rec. mentioned in 2)
    4) see the punctuation in $a -- it will be wrong (dash instead of
       semicolon between original $c and $f, no closing bracket)

    C.
    1) have $a active in one of the linking fields (like 461, 463, etc.).
    2) have a biblio record with the field 702 $a, $b, $c filled up
    3) go to cataloguing -> field 4XX of your choice, use the plugin to
       fetch data from biblio rec. mentioned in 2)
    4) see the punctuation in $a -- it will be wrong (unnecessary semicolon
       after original $c, n.b. lacking space).

    D.
    1) have $a active in one of the linking fields (like 461, 463, etc.).
    2) have a biblio record with the field 712 $a, $b filled up
    3) go to cataloguing -> field 4XX of your choice, use the plugin to
       fetch data from biblio rec. mentioned in b)
    4) see the punctuation in $a -- it will be wrong (unnecessary opening
       bracket at the end).

    Test plan, all tests and QA script pass.
    Thx Bernardo for his testing and explanations!

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 86c08e63a25afa86c9051f070d819ddac675425d)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit 70a6226cf7de15a74cb6f82dc14bf4568255fb95)
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    (cherry picked from commit 70a6226cf7de15a74cb6f82dc14bf4568255fb95)
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 8770b02fa4ca904f5ab209150242d24c3390544a)

commit ec0e086fde1895990750f8a1f9657996567e3fee
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Feb 1 10:40:50 2013 -0500

    Bug 9531: Make SIP2 message terminator configurable via SIPconfig.xml

    Add a terminator option to SIPConfig.xml, choices for 'terminator' are
    'CR' or 'CRLF'.  The default continues to be 'CRLF' if 'terminator' is
    undefined.

    Test Plan:
    1) Apply patch
    2) Start SIP server
    3) Run C4/SIP/t/04patron_status.t
    4) Stop SIP server
    5) Add terminator="CR" for account login 'term1'
    6) Run 04patron_status.t again, you should see no change

    Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
    Signed-off-by: Adrien Saurat <adrien.saurat at biblibre.com>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 90e2aafeb538f2d5e52fd1d32fce528f72076df8)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit b0474ebcf0a83cbbe8484b95986b350162959188)
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    (cherry picked from commit b0474ebcf0a83cbbe8484b95986b350162959188)
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 20e11030e5060bc7eab1734b45e3bd5e4ca0f5e9)

commit af1b555438f29c301e09cf0776da1811ec0ba394
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Mon Nov 12 10:18:30 2012 +0100

    Bug 9046: Followup FIX perl v.10 raises an error if itemnumbers if undefined

    If the itemnumbers parameter is undef, perl raises an error :
    "Can't use an undefined value as an ARRAY reference"

    Signed-off-by: Mason James <mtj at kohaaloha.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

commit 78474a0e99021d3d9e3a1bdc1a3cc3b59ab37b86
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Fri Nov 9 18:34:40 2012 +0100

    Bug 9046: FIX wrong test on an arrayref instead of an array

    EmbedItemsInMarcBiblio does not embed items when the itemnumbers param
    is given. That breaks the export tools (used from commandline).

    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-----------------------------------------------------------------------

Summary of changes:
 C4/Biblio.pm                                       |    3 +
 C4/SIP/Sip.pm                                      |   20 +-
 C4/SIP/Sip/MsgType.pm                              |   34 +-
 cataloguing/value_builder/unimarc_field_4XX.pl     |   16 +-
 etc/SIPconfig.xml                                  |    2 +-
 .../prog/en/modules/reports/catalogue_out.tt       |   53 ++--
 .../prog/en/xslt/UNIMARCslim2OPACResults.xsl       |    4 +
 reports/catalogue_out.pl                           |  330 +++++++++-----------
 8 files changed, 214 insertions(+), 248 deletions(-)

hooks/post-receive
-- 
main Koha release repository