[koha-commits] main Koha release repository branch master updated. v3.14.00-172-g95e2754

Git repo owner gitmaster at git.koha-community.org
Mon Dec 23 16:47:08 CET 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  95e2754af6a2dbd5f042a1c3504488f5de8c8d23 (commit)
      from  266f2a3a9f3d67fed0e0b35d267419a901345b92 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 95e2754af6a2dbd5f042a1c3504488f5de8c8d23
Author: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Date:   Sat Dec 14 12:07:11 2013 +0100

    Bug 9948: fix creation/updating of items when partially receiving an order
    
    Problem summary: when doing partial receives for the given order -
    1) if AcqCreateItem is set to 'ordering', various item data (price,
    dateaccessioned, replacementprice, replacementpricedate) are getting
    erroneously updated on the wrong (yet to be received == not the ones
    being currently received) item records
    2) if AcqCreateItem is set to 'receiving', newly received
    item records are being created without the aforementioned fields
    set to the proper values
    
    This (trivial) patch should deal with both cases, hopefully without
    breaking enything else.
    
    To test:
    - apply the patch,
    - create some orders with 2+ quantity
    - test partial & non-partial receives for those orders
    - ensure the received item records are getting modified
    (for AcqCreateItem set to 'ordering') and/or created (for AcqCreateItem
    set to 'receiving') correctly for both partial and non-partial receives
    - receiving orders with quantity = 1 / receiving orders in non-partial
    mode should be still working fine for 1) & 2) scenarios (i.e.,
    AcqCreateItem set to 'ordering' / AcqCreateItem set to 'receiving')
    
    Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
    
    Works as I'd expect now! Awesome patch.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.
    Also: t/db_dependent/Acquisition/
          t/db_dependent/Acquisition.t
    
    Created 2 orders with 3 items each for both settings
    of AcqCreateItem (on receive, on order) with the patches
    applied. No regressions found.
    
    Closed baskets and received shipments for each, with
    AcqCreateItem set according to how the order was created.
    
    First recreated the problem without the patches, reloaded
    database and confirmed that the patch fixes it.
    
    No problems found.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 acqui/finishreceive.pl |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list