[koha-commits] main Koha release repository branch 3.14.x updated. v3.14.01-10-gb91635d

Git repo owner gitmaster at git.koha-community.org
Tue Dec 24 10:48:18 CET 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.14.x has been updated
       via  b91635d802e6648c7708df72ba323c3f4b39efcc (commit)
       via  9959fca67510356ab9d7acd128c453d6008a2b73 (commit)
      from  7ab9a3961953a8739a047535e5997707ac83fd4a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b91635d802e6648c7708df72ba323c3f4b39efcc
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Fri Aug 30 11:41:26 2013 +0200

    Bug 10808: (follow-up) reformat auth_finder.pl
    
    Perltidy and some format changes.
    
    Most important : call to get_template_and_user must be at begining
    of script because it checks authentification.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Testing notes:
    - Tested various searches, selections now remain after
      submitting the search form.
    Regression testing:
    - Clearing the authority from the record still works.
    - Creating a new authority from the plugin page
      still works.
    - Autocomplete of entries still works.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit ca29e0658c469abff1e54e8630fb989757d02f71)
    Signed-off-by: Fridolin SOMERS <fridolin.somers at biblibre.com>

commit 9959fca67510356ab9d7acd128c453d6008a2b73
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Fri Aug 30 10:54:00 2013 +0200

    Bug 10808: make authority search form retain drop-down selections
    
    When cataloging a field defined with a thesaurus, an authority search
    popup is displayed with a search from. Once operators, values and sort
    selected in this form the search can be performed. The bug is that the
    values entered are kept but not the selected operators and sort.
    
    The same bug was existing in authorities module, solved by Bug 8692.
    
    This patch corrects the bug.
    
    Also uses in 'sort by' options the same text as search in authorities
    module : Heading A-Z (default), Heading Z-A, None.
    
    Also removes duplicated code in auth_finder.pl :
        value_mainstr => $query->param('value_mainstr') || "", ...
    
    Test plan :
    - Create a new biblio with a framework containing a field linked to a
      thesaurus. For example : 600
    - Click on small icon of main entry. For example : 600$a
    => You get a search form with all operators to "contains" and sort by
       "Heading A-Z"
    - Enter a value in each text box and perform search
    => You get a search form with values in text boxes and all operators
       to "contains"
    - Select "starts with" in all operator comboboxes and perform search
    => You get a search form with all operators to "starts with"
    - Select "is exactly" in all operator comboboxes and perform search
    => You get a search form with all operators to "is exactly"
    - Select "Heading Z-A" in sort by and perform search
    => You get a search form with "Heading Z-A" in sort by
    - Select "None" in sort by and perform search
    => You get a search form with "None" in sort by
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Comment: With both patches applied no koha-qa errors
    
    Test
    1) Original behavior is whatever selection you do before patch,
    search form returns to default options
    2) After patch, selection remains
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    All tests and QA script pass, further comments on second patch.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 857547c992ea2b548712583d09602eda3787556c)
    Signed-off-by: Fridolin SOMERS <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 authorities/auth_finder.pl                         |  159 ++++++++++----------
 .../prog/en/includes/auth-finder-search.inc        |   66 +++++++-
 2 files changed, 141 insertions(+), 84 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list