[koha-commits] main Koha release repository branch master updated. v3.14.00-204-g612e7e5
Git repo owner
gitmaster at git.koha-community.org
Fri Dec 27 01:20:34 CET 2013
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 612e7e5b7e7f0d218e69042e2b0f59df1646cf4f (commit)
via 3b9d8074b85b7d06c555491a75a48ac751560ec2 (commit)
via b5eab7c20bb8c2d07966bf1f68eaf0a7f953222e (commit)
via 1ebbf40ecc07b9474e81e20ec1598659ab027d7a (commit)
from 0fc114eee3f649abea88a62502211c595c2867b8 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 612e7e5b7e7f0d218e69042e2b0f59df1646cf4f
Author: Galen Charlton <gmc at esilibrary.com>
Date: Fri Dec 27 00:37:19 2013 +0000
Bug 8018: DBRev 3.15.00.011
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 3b9d8074b85b7d06c555491a75a48ac751560ec2
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Mon Dec 23 19:49:14 2013 +0100
Bug 8018: (follow-up) fixing some wrong capitalization
Fixes capitalization in 2 places:
- Delete a subfield - Yes/No options
- Edit a subfield - Edit subfield
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit b5eab7c20bb8c2d07966bf1f68eaf0a7f953222e
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Thu Dec 12 12:24:11 2013 -0300
Bug 8018: (followup) make the default more explicit
This patch:
- Makes the new subfield tab show maxlength=9999 as default (instead of
empty-then-zero).
- Updates the help to make exlpicit that 0 or empty defaults to 9999.
- Assumes all the subfields created with maxlength=0 inadvertedly are
meant to mean "no limit" and hence update the database to reflect
that.
To test (this patch and Pablo's):
- Edit a MARC framework, edit some field's subfields.
- Use the 'New' tab to create a new subfield (choose an unused letter).
- See in "More constrains" that the "Max length" field is empty. Leave
it as-is.
- Save the changes (the new subfield).
- Edit the field again, verify that "Max length" is 0.
- Try tu use the framework and the the field/subfield just created
> FAIL
- Apply the patches, upgrade
- Try to use the framework/field/subfield > SUCCESS (0 was converted to
9999)
- Repeat from the begining, "Max length" should show 9999 on the new
subfield tab.
- Leave it empty, it is saved as 9999.
Edit: small typo
Sponsored-by: Universidad Nacionald de Cordoba
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes QA script and tests in t and xt.
Tested:
- deleting an existing subfield
- adding a new subfield with new default 9999
- editing the new subfield, changing value to 8888
- deleting new subfield
- adding new subfield, using 8888 as length
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 1ebbf40ecc07b9474e81e20ec1598659ab027d7a
Author: Pablo Bianchi <pablo.bianchi at gmail.com>
Date: Wed Dec 11 15:54:54 2013 -0300
Bug 8018: MARC framework max subfield length should default to 9999
The default value for the marc_subfield_structure.maxlenght is 9999
in the DB. Currently the template passes an empty value which is casted to
0 by the CGI.
This simple patch validates the input and converts to the default (9999)
if not defined or 0.
Another approach could be changing the 9999 default and/or treating 0 as
'no-limit'.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Works by defaulting 0 or "" to 9999.
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
-----------------------------------------------------------------------
Summary of changes:
admin/marc_subfields_structure.pl | 3 ++-
installer/data/mysql/updatedatabase.pl | 7 +++++++
.../prog/en/modules/admin/marc_subfields_structure.tt | 6 +++---
.../prog/en/modules/help/admin/marc_subfields_structure.tt | 2 +-
kohaversion.pl | 2 +-
5 files changed, 14 insertions(+), 6 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list