[koha-commits] main Koha release repository branch master updated. v3.14.00-214-g3e866d2

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  3e866d216db008e1ed8c8614f6758ad5118321df (commit)
       via  fb4025b67b45e60154f67b9acca3d56e4f5eb7c5 (commit)
      from  4a0f630f7f8c7f3c402defa5837bc470510ebb07 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3e866d216db008e1ed8c8614f6758ad5118321df
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Dec 18 16:12:00 2013 +0100

    Bug 10277: Add UT for C4::Context::IsSuperLibrarian
    
    Note that I modify the return value. Before this patch, it returned an
    empty string or 1. Now it returns 0 or 1.
    
    Test plan:
    - same as the original patch
    - verify that unit tests pass:
        prove t/Context.t
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script, including new tests.
    Checked the code and tested superlibrarian behaviour in some places:
    
    moremember.pl:
    With IndyBranches only superlibrarian can delete borrowers from
    other branches. Accessing the borrower with a direct link.
    OK
    
    C4/Members.pm
    With IndyBranches only superlibrarian can search for borrowres
    from other branches.
    OK
    
    tools/holidays.pl
    With IndyBranches only superlibrarian can edit holidays for other
    branches.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit fb4025b67b45e60154f67b9acca3d56e4f5eb7c5
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed May 15 11:04:07 2013 -0400

    Bug 10277 - Add C4::Context->IsSuperLibrarian()
    
    The method of checking the logged in user for superlibrarian privileges
    is obtuse ( $userenv && $userenv->{flags} % 2 != 1 ) to say the least.
    The codebase is littered with these lines, with no explanation given. It
    would be much better if we had one subroutine that returned a boolean
    value to tell us if the logged in user is a superlibrarian or not.
    
    Test Plan:
    1) Apply this patch
    2) Verify superlibrarian behavior remains unchanged
    
    Signed-off-by: Joel Sasse <jsasse at plumcreeklibrary.net>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Comments on second patch.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Acquisition.pm           |   15 ++++++---------
 C4/Branch.pm                |   10 +++++-----
 C4/Circulation.pm           |    2 +-
 C4/Context.pm               |   17 +++++++++++++++++
 C4/Items.pm                 |    6 +++---
 C4/Members.pm               |    8 ++++----
 C4/Serials.pm               |    2 +-
 C4/Suggestions.pm           |   16 ++++++++--------
 acqui/basket.pl             |    4 ++--
 acqui/neworderempty.pl      |    9 +++++----
 cataloguing/addbiblio.pl    |    9 +++++----
 cataloguing/additem.pl      |    9 +++++----
 circ/overdue.pl             |    9 +++++----
 circ/ysearch.pl             |   14 +++++++-------
 members/deletemem.pl        |    2 +-
 members/memberentry.pl      |    4 ++--
 members/moremember.pl       |   22 ++++++++++++++--------
 reserve/request.pl          |    2 +-
 serials/member-search.pl    |   11 +++++++----
 serials/subscription-add.pl |   10 ++++------
 suggestion/suggestion.pl    |    9 +++++----
 t/Context.t                 |   28 +++++++++++++++++++++++++---
 tools/export.pl             |    4 ++--
 tools/holidays.pl           |    9 +++++----
 24 files changed, 140 insertions(+), 91 deletions(-)


hooks/post-receive
-- 
main Koha release repository