[koha-commits] main Koha release repository branch 3.8.x updated. v3.08.09-16-g9086611

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.8.x has been updated
       via  9086611f2d9df1fe64ef85eed3444c5a9ca1ade0 (commit)
      from  8435eb78f5a304163c2d1c62553af9bee2834472 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9086611f2d9df1fe64ef85eed3444c5a9ca1ade0
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Thu Nov 29 16:58:27 2012 -0500

    Bug 9174: Fix itemtype image display in OPAC lists
    
    Prior to this patch, C4::VirtualShelves::Page did not make sure that
    the itemtype images that it chose when displaying itemtype images for
    biblio-level itemtypes were for the correct interface, so
    even on the OPAC the Intranet icons were requested. On standard
    installations, intranet-tmpl is not available to the OPAC.
    
    To test:
    1) Set noItemTypeImages to "Show" and item-level_items to "biblio record"
    2) Create a list and add an item with the default item type (942$c in
       MARC21) set to something with an itemtype image associated with it.
    3) View the list in the OPAC.
    4) If you are an a standard install, the itemtype image will be a broken
       link. If on a dev install, you can confirm with Firebug or the like
       that the image is pulled from /intranet-tmpl.
    5) Apply patch.
    6) Run `prove t/db_dependent/Koha.t` to confirm that the behavior of the
       routine used to retrieve the image URL is correct. (Note that you
       must have an item type with the code 'BK')
    7) Refresh the list, noting that the display is now correct/the image is
       pulled from opac-tmpl.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    It works as expected. All tests in Koha.t passed.
    Signed-off-by: Mason James <mtj at kohaaloha.com>
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
    
    Conflicts:
    
    	t/db_dependent/Koha.t
    
    Squashed with: Bug 9174 follow-up: Eliminate warning and fix POD
    
    Thanks to Marcel for spotting these issues.
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Mason James <mtj at kohaaloha.com>
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-----------------------------------------------------------------------

Summary of changes:
 C4/Koha.pm                |   10 ++++++----
 C4/VirtualShelves/Page.pm |    2 +-
 t/db_dependent/Koha.t     |    8 +++++++-
 3 files changed, 14 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
main Koha release repository