[koha-commits] main Koha release repository branch 3.10.x updated. v3.10.02-51-g924e855

Sat Feb 9 01:27:42 CET 2013

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.10.x has been updated
       via  924e855539d7adb8997524976c2e08725b5d67ba (commit)
       via  2e3139d42c1a6a72108739efb4300803fa71ebc7 (commit)
       via  176cb0c6b54d047181d88576fa3201c7e867e063 (commit)
       via  b93c6b0b1f06501d68a8bbb746a7d1871699d571 (commit)
       via  466dd25ad68985653b040105b24cd8ccb9355bd3 (commit)
      from  125dbd2c015300e39d8fa5be72c018a97d302100 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 924e855539d7adb8997524976c2e08725b5d67ba
Author: Adrien Saurat <adrien.saurat at biblibre.com>
Date:   Fri Dec 28 16:37:59 2012 +0100

    Bug 9329: Wrong message for already expired cards

    Previously users would see the same message whether their card was about
    to expire or was already expired. This patch adds a new message to
    handle cards which are about to expire, following the
    NotifyBorrowerDeparture system preference.

    TEST PLAN :

    The best way to test would to have at the same time :
    - a SQL client to change the expiry date of a borrower
    - an OPAC session opened for the same patron.

    Case 1: expiry date is set in the future
    -> no warning

    Case 2: expiry date is set in the near future (within the
    "NotifyBorrowerDeparture" system preference range)
    -> a warning says the card will expire on **date**

    Case 3: expiry date is set in the past
    -> before patch, same warning as Case 2
    -> after patch, new warning indicating that the card has expired

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Added description to the patch and copied test plan from the bug report.
    Patch passes test plan.

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

commit 2e3139d42c1a6a72108739efb4300803fa71ebc7
Author: Chris Cormack <chris at bigballofwax.co.nz>
Date:   Sat Feb 9 13:15:31 2013 +1300

    Follow up fixing the case of SQL

commit 176cb0c6b54d047181d88576fa3201c7e867e063
Author: Sophie Meynieux <sophie.meynieux at biblibre.com>
Date:   Wed Dec 26 17:36:45 2012 +0100

    Bug 9320 Pending reserves report should not show waiting items

        Test plan : * chose an item reserved by multiple patrons.
                    * return the item and confirm reservation =>
                      item is waiting to be picked up
                    * run circ/pendingreserves.pl
                        => without patch, this item is shown in the list
                        => with the patch, only really available items are show.

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Works according to test plan. The title with one waiting item appeared
    in pending holds report before the patch, doesn't appear after the
    patch.

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit b93c6b0b1f06501d68a8bbb746a7d1871699d571
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Tue Jan 22 18:40:25 2013 -0500

    Bug 9451: Quiet warnings and Plackify borrower_stats.pl

    There are several warnings and one non-Plack-compatible variable in
    reports/borrower_stats.pl.

    To test:
    1) Apply patch
    2) Use the borrower report wizard to create a report that includes an
       extended patron attribute.
    3) Check the logs, and make sure that you don't see any of the
       following messages:
       Variable "$period" is not available at
         /home/jcamins/kohaclone/reports/borrowers_stats.pl line 265.
       Use of uninitialized value in hash element at
         /home/jcamins/kohaclone/reports/borrowers_stats.pl line 375.
       Use of uninitialized value in hash element at
         /home/jcamins/kohaclone/reports/borrowers_stats.pl line 376.

    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

commit 466dd25ad68985653b040105b24cd8ccb9355bd3
Author: Liz Rea <liz at catalyst.net.nz>
Date:   Mon Jan 28 09:42:32 2013 +1300

    Bug 9499 - --itemscontent= option is undocumented in advanced-notice.pl cronjob + default date should be date_due, not issuedate

    To Test:

    Set up a borrower to receive due and/or predue notices.
    Define your predue and/or due notice to use <<items.content>>
    Give your borrower an issue that will trigger a notice to be sent
    (Example: Henry Acevedo has checked out a book that will be coming due tomorrow,
    he wants to receive predue notices 1 day in advance)

    On the command line, run (your paths may vary, these are mine):
    sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl -c -n

    Note that the date listed is the due date, not the issue date.

    Then run:
    sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl -c -n --itemscontent=issuedate,title,author,barcode

    Note that the date listed is the issue date, not the date due.

    Also run
    sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl --help

    Should show the help.

    sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl --man

    Should show the man page version of the help.

    sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl

    Should show the help. This script requires confirmation before running (-c or nothing is done).

    Note that the documentation refers to the --itemscontent= option and now allows --man as well as --help. Also it is a proper POD.

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Works as advertised according to the fine test plan.

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-----------------------------------------------------------------------

Summary of changes:
 circ/pendingreserves.pl                          |    3 +-
 koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt |    6 +
 misc/cronjobs/advance_notices.pl                 |  135 ++++++++++++++++++----
 opac/opac-user.pl                                |   21 ++--
 reports/borrowers_stats.pl                       |    3 +-
 5 files changed, 135 insertions(+), 33 deletions(-)

hooks/post-receive
-- 
main Koha release repository