[koha-commits] main Koha release repository branch 3.8.x updated. v3.08.09-27-g48d7058

Sat Feb 9 01:27:57 CET 2013

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.8.x has been updated
       via  48d7058b17e5eaf4a14b207d01158d23c0921722 (commit)
       via  2d4723c93c40aced0a3c52970b5fa0ecea5471a3 (commit)
       via  bc3e56a92909d03e5e9648270849b5d3d8b9cee1 (commit)
       via  ba296fbf4bb707278872ca7c6afbcbad34801346 (commit)
      from  6376a5ac5a5d529948d636a44103c66c51472777 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 48d7058b17e5eaf4a14b207d01158d23c0921722
Author: Adrien Saurat <adrien.saurat at biblibre.com>
Date:   Fri Dec 28 16:37:59 2012 +0100

    Bug 9329: Wrong message for already expired cards

    Previously users would see the same message whether their card was about
    to expire or was already expired. This patch adds a new message to
    handle cards which are about to expire, following the
    NotifyBorrowerDeparture system preference.

    TEST PLAN :

    The best way to test would to have at the same time :
    - a SQL client to change the expiry date of a borrower
    - an OPAC session opened for the same patron.

    Case 1: expiry date is set in the future
    -> no warning

    Case 2: expiry date is set in the near future (within the
    "NotifyBorrowerDeparture" system preference range)
    -> a warning says the card will expire on **date**

    Case 3: expiry date is set in the past
    -> before patch, same warning as Case 2
    -> after patch, new warning indicating that the card has expired

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Added description to the patch and copied test plan from the bug report.
    Patch passes test plan.

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

commit 2d4723c93c40aced0a3c52970b5fa0ecea5471a3
Author: Chris Cormack <chris at bigballofwax.co.nz>
Date:   Sat Feb 9 13:15:31 2013 +1300

    Follow up fixing the case of SQL

commit bc3e56a92909d03e5e9648270849b5d3d8b9cee1
Author: Sophie Meynieux <sophie.meynieux at biblibre.com>
Date:   Wed Dec 26 17:36:45 2012 +0100

    Bug 9320 Pending reserves report should not show waiting items

        Test plan : * chose an item reserved by multiple patrons.
                    * return the item and confirm reservation =>
                      item is waiting to be picked up
                    * run circ/pendingreserves.pl
                        => without patch, this item is shown in the list
                        => with the patch, only really available items are show.

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Works according to test plan. The title with one waiting item appeared
    in pending holds report before the patch, doesn't appear after the
    patch.

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

commit ba296fbf4bb707278872ca7c6afbcbad34801346
Author: Liz Rea <liz at catalyst.net.nz>
Date:   Mon Jan 28 09:42:32 2013 +1300

    Bug 9499 - --itemscontent= option is undocumented in advanced-notice.pl cronjob + default date should be date_due, not issuedate

    To Test:

    Set up a borrower to receive due and/or predue notices.
    Define your predue and/or due notice to use <<items.content>>
    Give your borrower an issue that will trigger a notice to be sent
    (Example: Henry Acevedo has checked out a book that will be coming due tomorrow,
    he wants to receive predue notices 1 day in advance)

    On the command line, run (your paths may vary, these are mine):
    sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl -c -n

    Note that the date listed is the due date, not the issue date.

    Then run:
    sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl -c -n --itemscontent=issuedate,title,author,barcode

    Note that the date listed is the issue date, not the date due.

    Also run
    sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl --help

    Should show the help.

    sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl --man

    Should show the man page version of the help.

    sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl

    Should show the help. This script requires confirmation before running (-c or nothing is done).

    Note that the documentation refers to the --itemscontent= option and now allows --man as well as --help. Also it is a proper POD.

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Works as advertised according to the fine test plan.

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-----------------------------------------------------------------------

Summary of changes:
 circ/pendingreserves.pl                          |    3 +-
 koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt |    6 +
 misc/cronjobs/advance_notices.pl                 |  135 ++++++++++++++++++----
 opac/opac-user.pl                                |   21 ++--
 4 files changed, 133 insertions(+), 32 deletions(-)

hooks/post-receive
-- 
main Koha release repository