[koha-commits] main Koha release repository branch new/bug_9587 created. v3.08.00-1899-g7f08964
Git repo owner
gitmaster at git.koha-community.org
Sun Feb 24 16:15:51 CET 2013
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, new/bug_9587 has been created
at 7f08964c9d62efe7730636a9553b4afe444dbbf7 (commit)
- Log -----------------------------------------------------------------
commit 7f08964c9d62efe7730636a9553b4afe444dbbf7
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Sun Feb 24 10:18:43 2013 -0500
Bug 9587: Increment version number
Database update for bug 9587 has been given version 3.11.00.022
commit 219ec8f8981489577762cb4f5629dcec208c9412
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date: Thu Feb 21 11:34:41 2013 +1300
Bug 9587 : Handling mismatched emails better
To test:
Sign in to Koha via persona using an email that doesn't exist in Koha
Before the patch you will get into an infinite redirect loop
After the patch it will give you an error message
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Comment: Work as described. No errors.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit d8d257225738c746c6235b89105af74be7ca74fc
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Sun Feb 17 16:20:48 2013 +0100
Bug 9587 : QA follow up - fix one tabulation character
Makes QA script happy.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit d03c8443a4c5a4549a3ee37df201f031b40b2f41
Author: Chris Cormack <chris at bigballofwax.co.nz>
Date: Sun Feb 17 22:44:01 2013 +1300
Bug 9587 Follow up to fix the problem Katrin identified
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Comment: Solve that problem, but now koha-qa complains about tabs
in C4/Context.pm.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Tests done:
1) System preference 'Persona' added correctly.
2) Persona off, normal login still possible
3) Persona on, Persona login works
4) Persona logout works
5) normal login still possible
6) normal logout still possible
Persona is off by default and uses the primary email address
from the patron account.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 8cb1ac85a2ceb3f371e32035d0380e216845b5f7
Author: Chris Cormack <chris at bigballofwax.co.nz>
Date: Tue Feb 12 14:16:35 2013 +1300
Bug 9587 : Followup removing a commented out warn that was annoying the qa tools
Not introduced by this work but no reason not to clean it
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Comment: no more complains from koha-qa
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 3e8f39015be53044460417218abd3dbf283d4887
Author: Chris Cormack <chris at bigballofwax.co.nz>
Date: Tue Feb 12 07:35:07 2013 +1300
Bug 9587 : Follow up, fixing tabs in C4/Auth.pm
And translation problem in masthead.inc
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 493dcede4891be13e2742b2169b5579d71ad0d40
Author: Chris Cormack <chris at bigballofwax.co.nz>
Date: Mon Feb 11 22:34:20 2013 +1300
Bug 9587 : Mozilla Persona login
Working on Mozilla Persona support (browser id)
This will let a user log into Koha using browser id, if their email
address used matches the email address inside Koha.
Once an assertion is received, we simply need to find the user that
matches that email address, and create a session for them.
opac/svc/login handles this part.
The nice thing about it is, the user doesn't have to do anything, like
linking their account. As long as the email address they are using to
identify themselves in browserid is the same as the one in Koha it
will just work.
This is covered by a systempreference, to allow people to do it, and
is of course totally opt in, it works alongside normal Koha (or any
other method) of login. So only those choosing to use it, need use it
Test Plan
1/ Make sure OPACBaseURL is set correctly
2/ Switch on the Persona syspref
3/ Make a borrower (or edit one) to have the email you plan to use as
the primary email
4/ Click sign in with email, make or use a persona account
5/ Logout
6/ Check you can still login and logout the normal way
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Comment: Works great.
It's not browser dependent, but tested with chrome, firefox, opera and safari.
Old an new login system works.
Minor errors, addresed in follow-up.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit c644598a04074bc5cadc7b50396533f17351ad12
Merge: da4df6a 63412f0
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Sun Feb 24 10:10:32 2013 -0500
Merge branch 'bug_8682' into 3.12-master
-----------------------------------------------------------------------
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list