[koha-commits] main Koha release repository branch 3.12.x updated. v3.12.01-24-ga2e89ed

Tue Jul 2 19:49:41 CEST 2013

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.12.x has been updated
       via  a2e89edf43b2946da0986a5c83b04a60dea04061 (commit)
       via  ab3163564e91921222c153897f786551fe59647e (commit)
       via  b88f16a4e99d533753e3d707239e94da019ce303 (commit)
       via  b440b965eb6e5d97ce58a37f0b9da381b44e45bd (commit)
       via  a7d116e2fe39a17dd076e1dc805239622b410418 (commit)
      from  96a92a874a9a673a0c9003f2cb8c25ac64244f0e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a2e89edf43b2946da0986a5c83b04a60dea04061
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Mon Jun 10 14:05:32 2013 +0200

    Bug 10439: fix bug preventing the library for a notice from being changed

    2 javascript functions should be apply only in a specific case, not for all
    views.

    Test plan:

    - Switch on the IndependentBranches pref and log
      in as a superlibrarian.
    - Try to change the library for a notice. Before the patch,
      no change is applied.
    - Try to create a new notice, changing the library from
      default in the process.  Before the patch, the notice
      is not created.

    The bug can also be reproduced when IndependentBranches is
    off, in which case the staff user need not be a superlibrarian.

    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 77a5e3e365a50b02c9f224d731e05de90fc667c9)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    Test plan works as advertised.

commit ab3163564e91921222c153897f786551fe59647e
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Thu Jun 13 14:20:43 2013 -0300

    Bug 10464: Patron search on placing a hold now supports autocomplete

    The patron search box for placing a hold request on a bib in the
    staff interface now supports autocomplete if the CircAutocompl
    system preference is enabled.

    This patch grabs the autocomplete handling javascript stuff from patron-search-box.inc
    and puts an adjusted version on reserve/request.tt.  It sets form and input
    IDs to match those configured in the autocomplete call, adjusted where needed to
    avoid name collisions with the patron-search-box.inc that is present everywhere.

    This patch also doubles the width of the patron search input field.

    To test:
    - On a biblio record, go to the Holds tab, mine looks like
      /cgi-bin/koha/reserve/request.pl?biblionumber=2
    - A search box is shown for patron searching.
    - Search for a patron: it works as usual.
    - Make sure CircAutocompl is "Don't try"
    - Apply the patch
    - Click the Holds tab again, and do the same search: functionality should remain intact.
    - Change CircAutocompl to "Try"
    - Click the Holds tab again
    - Autocomplete should show you the possible options, and once you choose one result,
      it should work as usual.

    Sponsored-by: Universidad Nacional de Córdoba
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.
    Adding a nice new autocomplete feature.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit dc94a9bef79dc6d186fe93d82dac10cab0468d24)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit b88f16a4e99d533753e3d707239e94da019ce303
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu May 30 18:23:55 2013 +0100

    Bug 766: remove CGI::scrolling_list from request.pl

    Let the template take care of generating the display.
    Lets at least part of request.pl be more succinct.

    To test, place a hold and search for the patron using a partial name.
    You should get a dropdown select list of patrons and be able to select
    the patron to hold for from there.

    The functionality should remain unimpaired after this patch is applied.

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 7668e19c9593da570cffb5cd4640fe175d739328)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit b440b965eb6e5d97ce58a37f0b9da381b44e45bd
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date:   Thu May 2 08:13:05 2013 -0300

    Bug 10141: improve editing of MARC21 bib 008/18-21 and 008/24-27

    This patch changes the MARC21 008 editing form to create dropdowns
    for each of the 008/18-21 (Illustrations) and 008/24-27 (Nature of contents)
    positions.

    To test:
    1) Edit or add a new bibliographic record
    2) Click on field 008 value builder, positions 18-21 and 24-27 only
    show an input text box
    3) Apply the patch
    4) Reload value_builder page, now each position (18-21,24-27) has
    its own dropdown.  Note that it may be necessary to clear
    the browser cache for the change to be visible.

    Similar changes could be made for the 006 value builder.

    Signed-off-by: David Cook <dcook at prosentient.com.au>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 6792ddd0e3606704eaa72bda2a39d5686129c70a)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    Works great, nice improvement

commit a7d116e2fe39a17dd076e1dc805239622b410418
Author: David Cook <dcook at prosentient.com.au>
Date:   Fri Jun 14 13:03:19 2013 +1000

    Bug 10466: fix glitch in OPAC display of titles saved to list

    When displaying (in the OPAC) the set of records saved to a list,
    an apparently random number (typically 33 or 34) is sometimes
    displayed at the end of the publication description.  In particular,
    this can occur when XSLT is *not* being used to display search results;
    this patch corrects the problem.

    Now for the technical details:

    This patch checks to see if "size" is undefined. If it is, we add a
    blank (i.e. "") value to it in place of undef.

    If we do not do this, calling "itemloo.size" will return the size
    of the "itemloo" hash, rather than the value for the "size" key.

    This is because "size" is a virtual method in Template Toolkit. It's
    uncertain why the value is retrieved for the "size" key when there is
    a defined value and why TT doesn't use the method instead, and that
    it uses "size" as a method only if there is either no "size" key or
    if the value tied to the "size" key is null/undef. This might be a
    feature or it might be a bug in TT...

    In the meantime, we will check to see if it's undefined. If it is,
    we'll give it a value.

    This bug has been identified in the opac-search.pl, search.pl and
    addbooks.pl pages before. To address it, we're currently checking
    if there is a "size" key, and if not...we're adding one with a blank
    value.

    This patch takes up that same idea, although I think it might be better
    to rename the variable before passing it to TT in case the behaviour
    of TT changes in the future in regards to how it handles virtual
    methods.

    N.B. Obviously, this only affects users not using XSLTs.

    --

    Test Plan:

    Before applying the patch:

    0) Make sure you have opac search result XSLT turned off

    1) Find bib records that do not have a 300$c (Dimensions) value.
    2) Find bib records that do have a 300$c (Dimensions) value.

    (N.B. These values should be stored in the `size` column of biblioitems).

    3) Add items from both sets of records to a List
    4) Note that records without a 300$c will display a number at the end
    of the "Publication" description/string. It should be something like
    33 or 34 in most cases.
    5) Note that records with a 300$c don't display this number. They just
    show the value from 300$c.

    Apply the patch.

    6) Clear your cache, refresh the page, etc.
    7) Note that the number (e.g. 33 or 34) has disappeared from the end
    of the "Publication" description/string.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Added a small comment at the end of this one line.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit ceada35e008e6a60b62f384ec386e80b03fe0130)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/VirtualShelves/Page.pm                          |    1 +
 .../cataloguing/value_builder/marc21_field_008.xml |  154 +++++++++++++++++++-
 .../prog/en/modules/reserve/request.tt             |   54 ++++++--
 .../intranet-tmpl/prog/en/modules/tools/letter.tt  |   10 +-
 reserve/request.pl                                 |   46 ++-----
 5 files changed, 213 insertions(+), 52 deletions(-)

hooks/post-receive
-- 
main Koha release repository