[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-773-g35d8886

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  35d888643f3b3c281e0212b04ed770d3a86ce1e1 (commit)
       via  2d47b85692152a34fcd89acc9ec9032558d46844 (commit)
      from  37b3ac65e1dd363db8cc12793980a273b8cc09f4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 35d888643f3b3c281e0212b04ed770d3a86ce1e1
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Sat Jul 6 17:14:00 2013 +0000

    Bug 10366: DBRev 3.13.00.010 - add AcqWarnOnDuplicateInvoice syspref
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 2d47b85692152a34fcd89acc9ec9032558d46844
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Tue May 28 23:03:59 2013 -0400

    Bug 10366: Alert librarian if an invoice number is duplicated
    
    Some vendors ship materials from the same invoice in multiple packages.
    In those cases, it would be good to notify the librarian when they enter
    a duplicate invoice number, so that they can continue receiving on the
    previously-created invoice, rather than creating an invoice with a
    duplicate number.
    
    To test:
    1) Apply patch and run database update.
    2) Make sure that you have created at least one invoice on
       acqui/parcels.pl and take note of the invoice number.
    3) Try to create an invoice with the same invoice number.
    4) Note that without changing your configuration this works exactly
       the same as before.
    5) Turn on the AcqWarnOnDuplicateInvoice system preference.
    6) Try to create a new invoice with the same number as the one you
       noted earlier.
    7) Make sure you get a warning about a duplicate invoice.
    8) Choose to receive on the existing invoice.
    9) Confirm that you are receiving on said existing invoice.
    10) Start the receiving process over, and this time choose "Create new
        invoice anyway."
    11) Confirm that you are now receiving on a new invoice.
    
    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.
    
    I have followed the test plan, but also checked some more things:
    - Checking the duplicate check works when you have the entered
      invoice number in your database multiple times already.
    - Checking that no duplicate message is shown if you enter the
      invoice number and it's already been used for an invoice from
      another vendor.
    
    Looks all good. I think the only thing we could argue about here
    is if this could be activated by default for new installations.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 acqui/parcels.pl                                   |   32 +++++++++++++++----
 installer/data/mysql/sysprefs.sql                  |    1 +
 installer/data/mysql/updatedatabase.pl             |   13 ++++++++
 .../intranet-tmpl/prog/en/modules/acqui/parcels.tt |   29 ++++++++++++++++++
 .../en/modules/admin/preferences/acquisitions.pref |    6 ++++
 kohaversion.pl                                     |    2 +-
 6 files changed, 75 insertions(+), 8 deletions(-)


hooks/post-receive
-- 
main Koha release repository