[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-804-g89cf013

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  89cf013a6fadcb1347151798f3fdab0d8c75cd15 (commit)
       via  57866d6b67c3f8b29290150f21c71395315a73fe (commit)
      from  275f405c8b3920634907e5e1f2ef8ccecf497868 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 89cf013a6fadcb1347151798f3fdab0d8c75cd15
Author: Robin Sheat <robin at catalyst.net.nz>
Date:   Tue Jul 16 02:06:40 2013 +1200

    Bug 10590 - parameterise the limit option
    
    The limit option was previously substituted directly into the query. The
    previous patch on bug 10590 filters it on input, but there's no reason
    not to have it made to work properly in the query for added safety.
    
    To test:
    
    [1] Go to the top checkouts report (http://OPAC/cgi-bin/koha/opac-topissues.pl)
    [2] Run the report several times, varying the filters on
        number of results and item type.
    [3] Verify the the list of top checkouts appears to be correct.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 57866d6b67c3f8b29290150f21c71395315a73fe
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Mon Jul 15 13:00:18 2013 +0200

    Bug 10590 - in opac-topissues limit param is not protected
    
    In opac-topissues page, the limit URL argument is directly added to SQL query.
    
    This patch adds protections : limit must only contain digits and must be lower than 100.
    
    Test plan :
    - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=10&branch=&itemtype=&timeLimit=999&do_it=1
    => You get the results of 10 most cheched-out of all time
    - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=&branch=&itemtype=&timeLimit=999&do_it=1
    => You get the results of 10 most cheched-out of all time
    - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=9999&branch=&itemtype=&timeLimit=999&do_it=1
    => You get the results of 100 most cheched-out of all time
    - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=WHERE&branch=&itemtype=&timeLimit=999&do_it=1
    => You get the results of 10 most cheched-out of all time
    
    Signed-off-by: Robin Sheat <robin at catalyst.net.nz>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 opac/opac-topissues.pl |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository