[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-808-gdba36a7

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  dba36a7a1216238a260ea5fbe2218627487e9f19 (commit)
       via  bce45b4bf55e82345efed2850d9cb5fd77f3c483 (commit)
      from  782e3251c043d3f3671e1eeff7b195939afd5db2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit dba36a7a1216238a260ea5fbe2218627487e9f19
Author: Jason Etheridge <jason at esilibrary.com>
Date:   Fri Mar 8 10:41:06 2013 -0500

    Bug 9770: fix sorting of Dewey call numbers that contain prefixes
    
    C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally.
    
    The subroutine get_class_sort_key tokenizes a call number string (splitting on
    periods and whitespace) and counts the number of tokens that solely contain
    digits.  If there is only one such digit group, a comment in the code states
    that it will pad said digit group.  However, the bug is that the code assumes
    said digit group is the first token, when this may not be the case.
    
    In practice, this can cause poor sorting when used a call number is in the form
    of PREFIX _space_ 3DIGITS.
    
    To test:
    
    [1] Create two item records whose class scheme is set to
        'ddc' (Dewey) and whose call numbers contain prefixes, e.g.,
        J DVD 700.1 ABC and J DVD 850 DEF.
    [2] Use the inventory tool to produce a list of item items that include
        the two created in step 1.  Obsere that that items are sorted
        in the incorrect order, with "J DVD 850 DEF" coming before
        "J DVD 700.1 ABC".  Alternatively, run the following SQL
        to see the incorrect sort order:
    
        SELECT cn_sort, itemcallnumber
        FROM items
        WHERE itemcallnumber LIKE 'J DVD%'
        ORDER BY cn_sort;
    
    [4] Apply this patch.
    [5] Run misc/maintenance/touch_all_items.pl to force cn_sort to be
        recalculated.
    [6] Repeat step 2 and verify that the call numbers are now sorted
        corrected.
    
    Signed-off-by: Jason Etheridge <jason at esilibrary.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit bce45b4bf55e82345efed2850d9cb5fd77f3c483
Author: Jason Etheridge <jason at esilibrary.com>
Date:   Fri Jun 21 15:31:32 2013 -0400

    Bug 9770: test case for sorting of Dewey call numbers that contain prefixes
    
    This adds a test for C4::ClassSortRoutine::Dewey to check that the
    call number "JR DVD 800.1" sorts before "JR DVD 900"
    
    To test:
    
    [1] Apply just this patch.
    [1] Run prove -v t/ClassSortRoutine_Dewey.t
    [2] Test #7 should fail.
    
    Signed-off-by: Jason Etheridge <jason at esilibrary.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes test plan and QA script.
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/ClassSortRoutine/Dewey.pm |    6 +++++-
 t/ClassSortRoutine_Dewey.t   |    6 +++++-
 2 files changed, 10 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository