[koha-commits] main Koha release repository branch 3.12.x updated. v3.12.01-43-gdceefcf

Mon Jul 15 18:31:17 CEST 2013

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.12.x has been updated
       via  dceefcfac1e54dbfa3e13174cc8a5d73acbf07fe (commit)
       via  2e77edf8dfa0350a6e20805e7fa39b97608c804e (commit)
       via  5867909f8866b4e68340b88817bfb95f51bc3c9e (commit)
      from  e54f0ca8ce3dd8bc2053b2058e18c211cd1e34f7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit dceefcfac1e54dbfa3e13174cc8a5d73acbf07fe
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Nov 27 11:16:14 2012 -0500

    Bug 7110: Renewal messages no longer displays in OPAC if OpacRenewalAllowed is disabled

    Prior to this patch, if a patron has fines which exceed the limit set by
    OPACFineNoRenewals but OPAC renewals are disallowed by OpacRenewalAllowed,
    a message was displayed in their OPAC summary like this:

    "Please note: You currently owe XXX in fines. Please pay your fines if you wish
    to renew your books."

    Information about outstanding fines in this case has no bearing on
    how the user sees his summary of checkouts; since the user cannot
    renew the loans from the OPAC regardless of their fine balance if
    OpacRenewalAllowed is not enabled, this patch removes the message.

    To test, try various combinations of OpacRenewalAllowed and
    OPACFineNoRenewals with a patron who has outstanding fines:

    - OpacRenewalAllowed ON and OPACFineNoRenewals ON (set to be triggered
      by the test patron's fines): Logging in to the OPAC the patron should
      see a warning on opac-user.pl about not being able to renew items
      because of fines.

    - OpacRenewalAllowed ON and OPACFineNoRenewals OFF (threshold high
      enough not to trigger a block): No warning appears.

    - OpacRenewalAllowed OFF and OPACFineNoRenewals ON: No warning appears.

    - OpacRenewalAllowed OFF and OPACFineNoRenewals OFF: No warning appears.

    If OpacRenewalAllowed is diabled and a patron's fines exceed the limit
    set by OPACFineNoRenewals they should see no message.

    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Passes koha-ql.pl and perlcritic

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 29edd3797a7c950664ebc3be272ad4dca2575a80)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 2e77edf8dfa0350a6e20805e7fa39b97608c804e
Author: Robin Sheat <robin at catalyst.net.nz>
Date:   Tue Jul 16 02:06:40 2013 +1200

    Bug 10590 - parameterise the limit option

    The limit option was previously substituted directly into the query. The
    previous patch on bug 10590 filters it on input, but there's no reason
    not to have it made to work properly in the query for added safety.

    To test:

    [1] Go to the top checkouts report (http://OPAC/cgi-bin/koha/opac-topissues.pl)
    [2] Run the report several times, varying the filters on
        number of results and item type.
    [3] Verify the the list of top checkouts appears to be correct.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 89cf013a6fadcb1347151798f3fdab0d8c75cd15)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 5867909f8866b4e68340b88817bfb95f51bc3c9e
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Mon Jul 15 13:00:18 2013 +0200

    Bug 10590 - in opac-topissues limit param is not protected

    In opac-topissues page, the limit URL argument is directly added to SQL query.

    This patch adds protections : limit must only contain digits and must be lower than 100.

    Test plan :
    - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=10&branch=&itemtype=&timeLimit=999&do_it=1
    => You get the results of 10 most cheched-out of all time
    - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=&branch=&itemtype=&timeLimit=999&do_it=1
    => You get the results of 10 most cheched-out of all time
    - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=9999&branch=&itemtype=&timeLimit=999&do_it=1
    => You get the results of 100 most cheched-out of all time
    - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=WHERE&branch=&itemtype=&timeLimit=999&do_it=1
    => You get the results of 10 most cheched-out of all time

    Signed-off-by: Robin Sheat <robin at catalyst.net.nz>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 57866d6b67c3f8b29290150f21c71395315a73fe)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt |    2 --
 opac/opac-topissues.pl                           |   10 ++++++----
 opac/opac-user.pl                                |    2 +-
 3 files changed, 7 insertions(+), 7 deletions(-)

hooks/post-receive
-- 
main Koha release repository