[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-830-g53f82b1

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  53f82b1d7d9b7f06da1032faf0800d624eb4c1d3 (commit)
      from  ff7f37202949bb6d60cdf30de4e237e6b1de93eb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 53f82b1d7d9b7f06da1032faf0800d624eb4c1d3
Author: David Cook <dcook at prosentient.com.au>
Date:   Fri Jul 5 12:00:36 2013 +1000

    Bug 10541: enable cross-browser AJAX in additem.js
    
    Currently, the additem.js is using "indexOf" to search
    for a value in an array. While this works in Chrome, Firefox,
    and IE > 9, it fails miserably in IE 8 and 7 (which don't have
    the indexOf method). This means that users aren't able to add
    items using the acquisitions module!
    
    Instead of using "indexOf", we should be using the jQuery function
    $.inArray. It was added in jQuery v1.2 (3.8.0 uses v1.3.2 so even
    our oldest supported release can use this method). It's perfectly
    cross-browser compatible...works in Chrome, Firefox, and every
    version of IE that I've tried (i.e. 7, 8, 9).
    
    Test Plan:
    
    Before applying patch:
    
    0) Switch to Internet Explorer 7, or 8, or 9, or 10.
    
    If you're using IE 9 or 10, you'll need to change the Document Mode to
    IE7 standards or IE8 standards.
    
    You can do this by opening Internet Explorer 9 or 10, pressing F12 (or
    clicking on the gear in the top right corner and choosing
    F12 Developer Tools), and then clicking on "Document Mode" on the
    top toolbar. There, you can change to IE7 or IE8 standards.
    
    N.B. This is not always a perfect emulation in every case, but this
    time it does show you the bug.
    
    1) Set the system preference AcqCreateItem to "receiving an order"
    2) Go to Acquisitions
    3) Either:
        a) Receive a shipment for a basket with items
        b) Create a new basket, create an order, close the basket, and
           then do 3a)
    4) In the "Item" fieldset, fill out some fields such as barcode,
       Date acquiried, Public note, etc.
    5) Click "Add" at the bottom of the fieldset
    6) Note that while the item may have been added, the "Item" fieldset
    is not being shown again. You may also notice a Javascript error
    appearing in a pop-up window or you might see a yellow warning flag
    on the bottom status bar.
    
    APPLY THE PATCH
    
    7) Do a full refresh of the page (hold down shift and press the refresh
    button on the browser next to the address bar), and try adding items
    again.
    8) Note that you receive no warnings and that items are added correctly
    as they would be in Firefox or Chrome.
    
    OPTIONALLY
    
    9) To be sure that I haven't broken anything, go through the same steps
    in IE9 (with IE9 standards) or Chrome or Firefox. Everything should be
    working.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Tested in IE10 in IE7 mode and IE9 mode. Also tested in Firefox.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Passes koha-qa.pl, works as advertised.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/js/additem.js |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository