[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-871-g2291c21

Wed Jul 24 06:54:49 CEST 2013

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  2291c217fb212725c1a98a9e06344be8f6c6bac5 (commit)
       via  334e00bf5ccea4658365af7a09081d1474fba0b1 (commit)
       via  1a58e8cde36d8f8b91d16dac50156812e42ea78f (commit)
       via  61522d06f138cd4280301c05e54e35c44914770c (commit)
       via  8d9e6f37109528f5d50f2b005d60489817934500 (commit)
       via  dd2185981de2bf6e8d14bcdd4b6ae0da6cf2cbed (commit)
       via  53fbfa2dde3fb1150be9e49a90d9974bd71368a0 (commit)
      from  faa43031e66d1544aa2c93befa3f849ba93806d7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2291c217fb212725c1a98a9e06344be8f6c6bac5
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Tue Jul 9 14:58:21 2013 +0000

    Bug 9394: (follow-up) stylistic tidying

    - fix identation in one line
    - remove a commented-out warn

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 334e00bf5ccea4658365af7a09081d1474fba0b1
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Tue Jul 23 21:06:30 2013 +0000

    Bug 9394: (follow-up) fix query column alias

    A change-and-replace went a tick too far.  This patch
    adjusts the column alias in the query run in MergeHolds()
    to reflect that the value being returned is the number of
    hold requests, not an ID.

    To test:

    [1] This patch should have no visible changes to behavior.  To
        verify, pick to bib records that have hold requests on them,
        then merge them together.  Verify that the merged bib
        contains sll of the hold requests on it.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 1a58e8cde36d8f8b91d16dac50156812e42ea78f
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Tue Jul 9 15:07:08 2013 +0000

    Bug 9394: (follow-up) restore ability to cancel holds from the patron summary

    To test:

    - Place a hold request for a patron
    - From the patron details page, navigate to the holds table,
      then cancel (delete) it.
    - Verify that the hold request is gone.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 61522d06f138cd4280301c05e54e35c44914770c
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Tue Jul 9 14:30:14 2013 +0000

    Bug 9394: (follow-up) silence spurious warns

    One just needed parentheses, but the one on line 219 reflects
    a slightly deeper problem -- it's running patron checks when
    a patron hasn't actually been supplied.

    To test:

    [1] From the staff interface, bring up a biblio that has no
        holds on it, then go to the holds tab.
    [2] Verify that the Apache log has no new warnings containing:

    request.pl: Use of uninitialized value in string eq at /home/gmc/koha/reserve/request.pl line 219

    or

    request.pl: Use of uninitialized value in string eq at /home/gmc/koha/reserve/request.pl line 488

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 8d9e6f37109528f5d50f2b005d60489817934500
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Tue Jul 9 14:13:38 2013 +0000

    Bug 9394: (follow-up) modernize test cases

    - wrap in a transaction
    - create the patron records needed for the test

    To test:

    [1] Run prove -v t/db_dependent/Holds.t
    [2] Verify that all tests have passed.
    [3] Verify that the additional patron records created
        by the test no longer exist in the database.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit dd2185981de2bf6e8d14bcdd4b6ae0da6cf2cbed
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed May 29 14:38:40 2013 +0200

    Bug 9394: QA Followup

    * C4::Reserves::_FixPriority
      - The previous code checked the cancellationdate. If think you never pass
    in it with bad parameters, but in order to be sure I added the check on
    this value.
      - The reservedates array was never used.

    * circ/circulation.tt
    There was a bug: it was not possible to remove an hold from the
    circulation page. Passing reserve_id fixes the issue.

    * C4::Reserves::GetReserveId
    This subroutine did not have a unit test.

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 53fbfa2dde3fb1150be9e49a90d9974bd71368a0
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue Jan 15 10:13:52 2013 -0500

    Bug 9394: Use reserve_id where possible

    This patch switches from using a combination of
    biblionumber/borrowernumber to using reserve_id where possible.

    Test Plan:
    1) Apply patch
    2) Run t/db_dependent/Holds.t

    Signed-off-by: Maxime Pelletier <maxime.pelletier at libeo.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Biblio.pm                                       |    2 +-
 C4/ILSDI/Services.pm                               |    2 +-
 C4/Reserves.pm                                     |  521 ++++++++++----------
 C4/SIP/ILS/Transaction/Hold.pm                     |   23 +-
 circ/branchtransfers.pl                            |   10 +-
 circ/circulation.pl                                |    2 +-
 .../prog/en/modules/circ/circulation.tt            |    2 +-
 .../prog/en/modules/members/moremember.tt          |    1 +
 .../prog/en/modules/reserve/request.tt             |   21 +-
 koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt   |    2 +-
 members/moremember.pl                              |    1 +
 opac/opac-modrequest.pl                            |    9 +-
 reserve/modrequest.pl                              |   28 +-
 reserve/request.pl                                 |   73 ++--
 serials/routing-preview.pl                         |    7 +-
 t/db_dependent/Holds.t                             |  176 +++++++
 16 files changed, 541 insertions(+), 339 deletions(-)
 create mode 100755 t/db_dependent/Holds.t

hooks/post-receive
-- 
main Koha release repository