[koha-commits] main Koha release repository branch 3.2.x updated. v3.02.11-3-g5f0384d
Git repo owner
gitmaster at git.koha-community.org
Tue Jul 30 00:32:05 CEST 2013
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 3.2.x has been updated
via 5f0384d42f1427ac680891c2f535c327b1fadf26 (commit)
via 45aa375aae1ab7c1ca453ad838b37160371df845 (commit)
via 96434ba3a373f01cc340c7299700ee147edbb3b6 (commit)
from 12f7c5d1ca377e266ed4a1382edb287d24cf366f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 5f0384d42f1427ac680891c2f535c327b1fadf26
Author: Galen Charlton <gmc at esilibrary.com>
Date: Sun Jul 28 19:42:51 2013 +0000
move Auth_ParseSearchHistoryCookie.t to db_dependent directory
The actual tests in this script are not dependent on the database,
but simply loading C4::Auth requires a valid(ish) koha-conf.xml
and database.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 45aa375aae1ab7c1ca453ad838b37160371df845
Author: Galen Charlton <gmc at esilibrary.com>
Date: Sun Jul 28 02:48:44 2013 +0000
do some validation of the KohaOpacRecentSearches cookie
Add validation of the value of the KohaOpacRecentSearches. In
particular, this patch avoids the generation of an internal server
error when the OPAC is presented with an old cookie that uses the
old Storable-based serialization.
This patch also moves parsing of the cookie value into a
new routine in C4::Auth, ParseSearchHistoryCookie, and adds
a test case.
To test (in conjunction with the previous patch):
Exercise the OPAC search history functionality, after
turning on the EnableOpacSearchHistory syspref:
- As an anonymous user, conduct a variety of searches,
including ones that include non-ASCII characters
- Check the search history and verify that all searches
are listed
- Apply this patch and the previous one.
- Do *not* clear the KohaOpacRecentSearches cookie
- Check the search history and verify that no searches
are listed any more
- As an anonymous user, conduct a variety of searches,
including ones that include non-ASCII characters
- Check the search history and verify that all searches
are listed
- Log into the OPAC
- Verify that current and past searches are listed in
search history.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 96434ba3a373f01cc340c7299700ee147edbb3b6
Author: Galen Charlton <gmc at esilibrary.com>
Date: Thu Jul 25 16:50:30 2013 +0000
use JSON rather than Storable for the OPAC search history cookie
To test:
Exercise the OPAC search history functionality, after
turning on the EnableOpacSearchHistory syspref:
- Clear the KohaOpacRecentSearches cookie
- As an anonymous user, conduct a variety of searches,
including ones that include non-ASCII characters
- Check the search history and verified that all searches
are listed
- Log into the OPAC
- Verify that current and past searches are listed in
search history.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Auth.pm | 32 ++++++++++--------
opac/opac-search-history.pl | 12 ++----
opac/opac-search.pl | 24 ++++---------
t/db_dependent/Auth_ParseSearchHistoryCookie.t | 43 ++++++++++++++++++++++++
4 files changed, 72 insertions(+), 39 deletions(-)
create mode 100644 t/db_dependent/Auth_ParseSearchHistoryCookie.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list