[koha-commits] main Koha release repository branch 3.10.x updated. v3.10.03-21-ge2662c7
Git repo owner
gitmaster at git.koha-community.org
Mon Mar 11 10:34:37 CET 2013
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 3.10.x has been updated
via e2662c7b04e54b320d62ccfeb0142c8a97764e23 (commit)
via 8c394e3598121d1d079c6eca591c40ede37853e1 (commit)
via 3db006c3b9ce97167c31f96a4e37c2be67bfce96 (commit)
via 555a9e02f4eb8cba233cb900e8e94521cbb1bdda (commit)
via 71b7da6de50b462ce36b9d912c778d8e7bd82987 (commit)
from e1455f48457d568a31c1eb967fd626d4c9d4223c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit e2662c7b04e54b320d62ccfeb0142c8a97764e23
Author: Katrin Fischer <katrin.fischer at bsz-bw.de>
Date: Fri Feb 15 17:55:38 2013 +0100
Bug 9620: IncludeSeeFromInSearches and data in $9 subfields can break indexing
In Germany 020$9 is used to store the ISBN with hyphens. In rare cases this
can break indexing in combination with IncludeSeeFromInSearches.
To reproduce:
1) Change your frameworks:
* Make sure 084 $a is visible
* Create a 084 $9 that you link to PERSO_NAME authorities.
2) Create a record or edit an existing one:
* Use the plugin on 084 to link the record to an authority.
* Make sure 400 is filled in your authority record.
Preparations all done, now test indexing:
3) Make sure IncludeSeeFromInSearches is OFF
* Reindexing should work without any problems.
4) Activate IncludeSeeFromInSearches
* Reindexing should throw an error and stop:
201.Subfields are only for data fields (generally,
just tags >= 010 at /home/koha/Koha/Filter/MARC/EmbedSee
FromHeadings.pm line 94
5) Apply patch and reindex.
* No error should occur.
* Test 4xx fields from other tags were properly indexed.
What causes the problem is the fact, that Koha tries to store
the date from the 400 in the bibliographic record for indexing.
For this it calculates a tag in the bibliographic record from the
tag it found the authority link in and the 4xx tags used in the
authority record. If you have an authority linked to a 0xx field
and the matching authority has a 4xx where xx < 10, the calculated
tag will be a control field. The attempt to add subfields to this
control field, is causing the error and breaks the indexing process.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Comment: Work as described, and is a long description :)
Test:
1) Enabled 084 (all subfields visible), added 084_9 (missing from
default framework) linked to PERSO_NAME
2) Edited authority record and added some data to 400
3) Edited bib record, linked 084 to previous auth record
4) With IncludeSeeFromInSearches OFF, re-index without problem
5) With IncludeSeeFromInSearches ON, re-index problems!!!
====================
exporting biblio
====================
1...Subfields are only for data fields (generally, just tags >= 010) at...
Abort
6) Applied patch
7) With IncludeSeeFromInSearches ON, re-index without problem
...
====================
5001....................................................................................................
Records exported: 5060
====================
...
====================
2001....................................................................................................
Records exported: 2024
====================
CLEANING
====================
Good!
*) That's "works as described", don't know if other tests are needed.
No errors from koha-qa
Signed-off-by: Elliott Davis <elliott at bywatersolions.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
commit 8c394e3598121d1d079c6eca591c40ede37853e1
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Thu Feb 28 14:09:24 2013 +0100
Bug 9656: Followup Make logging to a file optional (for fines)
The -log option become optional if the -output_dir is given.
Test plan:
call the script with
1/ no one parameter : no log file
2/ -l : log file will be created in /tmp
3/ -o=/home/koha/var/log : log file with be created in the specified
4/ -o=/home/koha/var/log -l: Same as 3/
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Comment: All combination of options tested. Works well. No errors.
Signed-off-by: Elliott Davis <elliott at bywatersolions.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
commit 3db006c3b9ce97167c31f96a4e37c2be67bfce96
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date: Thu Feb 21 22:10:48 2013 +1300
Bug 9656: Make logging to a file optional (for fines)
To test:
1/ Before the patch run misc/cronjobs/fines.pl
Notice that a file has been written to /tmp
2/ rm the file
3/ Apply the patch and run the script again
Notice the file is not created
4/ run the script with -l
Notice the file is created again
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Comment: Now it work as described. No errors.
Signed-off-by: Elliott Davis <elliott at bywatersolions.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
commit 555a9e02f4eb8cba233cb900e8e94521cbb1bdda
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Mon Mar 4 16:10:34 2013 -0500
Bug 8620: Any index in DOM mode sensitive to -x flag of rebuild_zebra.pl
The definition of the Any index was sensitive to whether
spaces were present between (say) subfield elements in the
MARCXML representation of the bib being indexed. When using
the -x option to rebuild_zebra.pl, spaces would be present
because of how MARC::File::XML emits MARCXML.
When not using the -x option, spaces would not be present
and the contents of a field would be run together, potentially
as one big token.
The visible behavior was that doing a keyword search by
item barcode would sometimes not work.
To test:
0) Make sure Zebra is using DOM mode
1) Create an item record.
2) Reindex using rebuild_zebra.pl -b -z, *without* -x
3) Do a keyword search by the barcode of the item just
added; the search shouldn't work
4) Apply patch.
5) Update the following two files:
etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl
etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl
6) Reindex
7) Do a search that was previously failing.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Fixes the problem for me - formerly not working callnumbers
and barcodes are now found in keyword (any) searches.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
(revised commit description to better explain why it fixes the problem)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Passes all my tests, happy to sign off
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
commit 71b7da6de50b462ce36b9d912c778d8e7bd82987
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Sun Feb 10 13:25:44 2013 -0500
Bug 9574: Plack fixes for serials/subscription-add.pl
This patch fixes the following warnings under Plack:
* Use of uninitialized value $firstissuedate in string eq at \
/home/jcamins/kohaclone/serials/subscription-add.pl line 92.
* Use of uninitialized value $firstissuedate in substr at \
/home/jcamins/kohaclone/serials/subscription-add.pl line 105.
* Use of qw(...) as parentheses is deprecated at \
/home/jcamins/kohaclone/serials/subscription-add.pl line 95.
* Variable "$firstissuedate" is not available at \
/home/jcamins/kohaclone/serials/subscription-add.pl line 338.
To test:
1) Create a subscription. Ensure that setting the first issue's
publication date works.
2) Edit a subscription. Ensure that the first issue's publication
date shows up.
3) Sign off.
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
No regressions found, all tests and QA script pass.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
-----------------------------------------------------------------------
Summary of changes:
Koha/Filter/MARC/EmbedSeeFromHeadings.pm | 1 +
.../marc21/biblios/biblio-zebra-indexdefs.xsl | 3 +-
etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl | 3 +-
misc/cronjobs/fines.pl | 48 +++++++++++++------
serials/subscription-add.pl | 6 +-
5 files changed, 41 insertions(+), 20 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list