[koha-commits] main Koha release repository branch new/bug_9239 created. v3.08.00-2073-g5fbedc0
Git repo owner
gitmaster at git.koha-community.org
Sun Mar 17 02:34:41 CET 2013
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, new/bug_9239 has been created
at 5fbedc0c9e92a313bbeb6164d182ba568a137fd1 (commit)
- Log -----------------------------------------------------------------
commit 5fbedc0c9e92a313bbeb6164d182ba568a137fd1
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Sat Mar 16 21:38:36 2013 -0400
Bug 9239: Increment version number
Database update for bug 9239 has been given version 3.11.00.029
commit a8d7ad5be8fd7113e385ff66e067172cc57ff43d
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Sat Mar 16 21:34:01 2013 -0400
Bug 9239: Disable QP by default
commit 181dab6699962cc460e2296206c5f901e31f9fd7
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Thu Mar 14 14:02:26 2013 -0400
Bug 9239 QA follow-up: fix overeager quote escaping
The quote escaping added two follow-ups ago was a little too eager,
and escaped perfectly valid quotes in some instances. This patch moves
the escaping deeper into the loop so that no needed quotes will be
escaped.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Test plan included here, as this is the last patch in the series:
All tests pass.
OPAC
Simple search
- Keyword searches using boolean operators || and && - OK
- Pubdate searches using pubdate() - OK
- Using different search options: keyword, title, etc. - OK
Facets
- limit to available from a query parser simple search - OK
- Other facets - OK
Advanced search
- Date range search - OK
- Itemtype limits - OK
- Language limit - OK
- Combining various serach options with and without 'more' options
and using boolean operators - OK
Authorities
- Searching for partial and complete names like "M", "Benedictus" works. - OK
- Biblio count isc correct - OK
- Links to linked biblios work. - OK.
INTRANET
Staged MARC import
- Import records using various matching points - OK
Serials
- Search for a serial in subscription form - OK
Acquisitions
- Search for existing record from basket - OK
Authorities
- Running the linker script with QP on works. - OK
- Searching for authorities works. - OK
- Biblio count isc correct - OK
- Links to linked biblios work. - OK.
NOTE: As agreed with Jared in chat, query parser should be
off by default for the next release.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 8dcec411a43d787341fc39eef2d3b271b820fe08
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Thu Mar 14 12:14:16 2013 -0400
Bug 9239 QA follow-up: amend error handling
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 241656582c7d157b03ec1316fbf705bccab899bc
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Thu Mar 14 10:50:41 2013 -0400
Bug 9239 QA follow-up: escape quotes in searches
This patch escapes quotes in searches for those rare instances where
there is a literal quote inside a search term.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit c716c28fa66f0e5f2ff14da43f4c4d7dd907ae2f
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Thu Mar 14 08:43:13 2013 -0400
Bug 9239 QA follow-up: better error handling
* Fix a long-standing bug in the linker that could crash the linker when
run against odd data.
* Sanitize input to SimpleSearch.
* Correctly handle CCL indexes with QP.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 376c55dc4ec13abb00e4527d5b4c3c513c8e9ff3
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Thu Mar 14 10:11:16 2013 -0400
Bug 9239 QA follow-up: remove stray debug code
Remove a line of debug code from EG, provide better error handling
when presented with weird data in the authority linker, and correct
queryparser configuration to reflect the correct configuration for
Zebra.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 31b105ad110579173f78e8a12435bede11f732f5
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Mon Mar 11 18:35:39 2013 -0400
Bug 9239 QA follow-up: don't fall back to kw if field is specified
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit d88bd37f30d4b1ae52d0237582c1b927aa276b4d
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Sun Mar 10 09:17:21 2013 -0400
Bug 9239 QA follow-up: the last QA follow-up was missing a require
This patch also corrects the definition of the an= index, which was
missing exactness.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit a8f23264dda90eda5123ce98b7bb5a0b5e951fa6
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Sat Mar 9 09:59:51 2013 -0500
Bug 9239 QA follow-up: escape CGI input
Koha was not previously escaping CGI input, which caused problems for
highlighting and is a security issue.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Thx for fixing this.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 006df7aced85179e77745824d24b453464ca9382
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Thu Mar 7 06:50:10 2013 -0500
Bug 9239 QA-follow-up: quiet warnings and fix problem with limits
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit ed521b8ebbedf7ce4b8f75fcafdaa7135f6ee49d
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Mon Mar 4 12:55:12 2013 -0500
Bug 9239 QA follow-up: fix highlighting and merge error
QP searches with && broke search highlighting on the OPAC details page.
This patch corrects encoding of the query_desc parameter that is passed
to the details page.
My last attempt at rebasing also transposed the variable for index
names with the variable for operators, meaning that the dropdown in
the basic search did not work.
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Fixes some problems raised during QA successfully.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 09de3b93be2a294442576fba606ef434e2ea11a0
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Wed Feb 6 14:03:03 2013 -0500
Bug 9239 follow-up: update koha-conf.xml
The previous patches were missing the koha-conf.xml updates. This patch
updates koha-conf.xml and makes the changes neccessary to include the
QueryParser configuration file in the packages.
To test:
1) Run Makefile and check generated koha-conf.xml to confirm that the
line <queryparser_config>...</queryparser_config> is there with an
absolute path.
2) That was it.
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Tested update successfully - new line now shows up and
query parser is used.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 9d450224c185683ddbbd9c2c0a7b0266c50e99a5
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Fri Jan 25 07:45:22 2013 -0500
Bug 9239 follow-up: POD and perlcritic fixes
There were several perlcritic violations for returning explicit undef,
and splitting up the various driver classes resulted in POD compliance
errors, where the POD was starting with head2 rather than head1. This
patch fixes those errors (but has no functional impact).
Signed-off-by: Elliott Davis <elliott at bywatersolions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 144c7f4e4e023f7a701a1e58524409628295343b
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Tue Dec 11 12:52:40 2012 -0500
Bug 9239: Allow the use of QueryParser for all queries
With the inclusion of this patch, all searches will (try) to use
QueryParser for handling queries for both the bibliographic and authority
databases if UseQueryParser is enabled. If QueryParser is unavailable,
UseQueryParser is disabled, or the search uses CCL indexes, the old
search code will be used.
To test:
1) Apply patch.
2) Run the unit test with `prove t/QueryParser.t`
3) Enable the UseQueryParser syspref.
4) Try searches that should return results in the following places:
* OPAC (simple search)
* OPAC (advanced search)
* OPAC (authorities)
* Staff client (header search)
* Staff client (advanced search)
* Staff client (cataloging search)
* Staff client (authorities)
* Staff client (importing a batch using a match point)
* Staff client (searching for an item for adding to a label)
* Staff client (acquisitions)
* Staff client (searching for a record to create a serial)
* ANYWHERE ELSE I HAVE FORGOTTEN
5) Disable the UseQueryParser syspref. Repeat at least some of the
searches you did above.
6) If all searches worked, sign off.
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Elliott Davis <elliott at bywatersolions.com>
Searching still works as expected for variuos places.
QueryParser syspref seemed to be enabled by default
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit b086fcab9a32c8fc7cbca99e5d23a5323603c7b6
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Tue Dec 11 12:16:20 2012 -0500
Bug 9239: Add syspref to enable QueryParser
In light of the experimental nature of the QueryParser code at this
juncture, it behooves Koha to have the option of disabling QP, at least
for the purpose of comparing results between QP-enabled and QP-disabled
searches. This patch adds a UseQueryParser syspref to do just that. In
cases where the user enables QP without having QP installed, however,
there will be no dramatic failure, and Koha will simply fall back to
using the non-QP search code.
In order to reduce the overhead added by the introduction of QueryParser,
this patch adds a C4::Context->queryparser accessor to a static
QueryParser object which is initialized the first time it is required
and then reset thereafter.
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Elliott Davis <elliott at bywatersolions.com>
Fixed merge conflict in sysprefs.sql and updatedatabase.sql
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Fixed merge conflict in sysprefs.sql und updatedatabase.pl
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 2900bd14dcd02bf9ac9912c7e620c8e67d62c01c
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Tue Oct 2 17:06:47 2012 -0400
Bug 9239: Introduce QueryParser driver for PQF
Since the most expressive query language supported by Zebra is PQF, this
patch adds a PQF driver for QueryParser which will translate QueryParser
queries into standard PQF (guided by mappings which have been written to
match Koha's existing Zebra configuration) which can then be sent to
Zebra. This driver, Koha::QueryParser::Driver::PQF(::*) extends the
OpenILS::QueryParser(::*) class(es), so as to preserve maximum
interoperability between the various users of the QueryParser driver.
Initially, search syntax is as follows:
* AND operator: &&
* OR operator: ||
* GROUPING operators: ( )
Fields can mostly be searched using the ccl prefixes they have now. The
exception is the various date limits which are searched with a syntax
like this: pubdate(2008)
For sorting, you can simply add #title-sort-az (etc.) to your query.
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Elliott Davis <elliott at bywatersolions.com>
Test Passed successfully after installing missing dep for Test::Deep
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 2a202740ffb881ded4ce8341cdbb989c245eafac
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Tue Dec 11 15:54:48 2012 -0500
Bug 9239: Add QueryParser module to Koha
Although the OpenILS::QueryParser class is going to be moved into a
separate CPAN distribution, this hasn't been done yet, and for ease of
testing it makes sense to include the class in Koha for the moment.
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Elliott Davis <elliott at bywatersolions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
-----------------------------------------------------------------------
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list