[koha-commits] main Koha release repository branch new/bug_9504 created. v3.12.00-alpha-42-ge343165
Git repo owner
gitmaster at git.koha-community.org
Wed Mar 20 13:32:43 CET 2013
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, new/bug_9504 has been created
at e343165cf6a32ffa13f192c2961ed5a63c0202f1 (commit)
- Log -----------------------------------------------------------------
commit e343165cf6a32ffa13f192c2961ed5a63c0202f1
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date: Tue Jan 29 18:03:02 2013 +0100
Bug 9504: URL escape in OPAC more searches
OPACSearchForTitleIn is a syspref used to add links as "more searches" in OPAC record detail page.
The links can contain vars depending on record values like title, ISBN, ...
Thoses values must be URL-escaped because they can contain special characters that will brake URL and/or HTML.
This patch add a method C4::Output::parametrized_url() that replaces vars in URL usign escape and UTF-8 encoding.
Test plan :
- Define in OPACSearchForTitleIn a link with all possible vars : TITLE, AUTHOR, ISBN, ISSN, CONTROLNUMBER, BIBLIONUMBER
- Edit a record to add special characters in title : ", &, ? ...
- Go to OPAC detail pages of this record
=> Check that URL is well encoded
=> Click on link to check the term is well encoded (diacritical characters, ...)
Signed-off-by: Liz Rea <liz at catalyst.net.nz>
Nice test plan, thanks!
Verified bug and fix - both look good.
Signed-off-by: Mason James <mtj at kohaaloha.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 7db1cc4235a2b7e7321a80d98929e4900c0437a8
Merge: 5ca45b8 a06fd22
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Wed Mar 20 08:05:07 2013 -0400
Merge branch 'bug_7018' into 3.12-master
-----------------------------------------------------------------------
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list