[koha-commits] main Koha release repository branch new/bug_4354 created. v3.12.00-alpha2-84-g2a7d29b
Git repo owner
gitmaster at git.koha-community.org
Fri Mar 22 01:03:49 CET 2013
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, new/bug_4354 has been created
at 2a7d29beb3f7ef2dd5e83ff0e35d19ca8bcfe82e (commit)
- Log -----------------------------------------------------------------
commit 2a7d29beb3f7ef2dd5e83ff0e35d19ca8bcfe82e
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Thu Mar 21 20:04:09 2013 -0400
Bug 4354 follow-up: correct phrasing of alert
Rather than saying "Are you sure you want to lost your changes" the
message that pops up when a user cancels changes to an existing row
should be "Are you sure you want to cancel your changes?" or something
along those lines. I went with that exact string.
commit 1cb51d7685a4d2fb4228dbb567aa03808b721d54
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Thu Mar 21 15:43:01 2013 +0100
Bug 4354: Manage the specific case "Unlimited" value
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
All good :)
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit b8c8856840ebcef2639274be2424e783e476fa67
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Thu Mar 21 12:32:43 2013 +0100
Bug 4354: Followup: FIX the hardduedate copy
Before this patch, the copy was based on the string (could be
translated!). Now is base on the -1, 0, 1 values.
The trick is to backup the hardduedatecompare value for each line of the
table.
Signed-off-by: Cedric Vita <cedric.vita at dracenie.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 4243b517214f95964c69da269d75f1746b5c897f
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Mar 18 12:41:56 2013 +0100
Bug 4354: Followup Add a Cancel button
New cancel button on the edit row.
Add a prevent message when editing a new row.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 8367e9628b1a334e7c25917ce6761c804bc76776
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Jan 24 09:21:34 2013 -0500
Bug 4354 - Followup - Add row highlighting
Test plan:
* Click on a row to edit
* Note that the row is highlighted in orange
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
All tests pass.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 3b0109537849c6c23535b447254922072729ad05
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Wed Jan 16 16:51:13 2013 +0100
Bug 4354: Cannot edit existing issuing rules
This patch adds javascript which pulls the values from the
chosen row of data and populates the last row's form with
that data. Some changes have been made to the markup to
better accommodate this.
Possibly missing is some kind of visual feedback to the user
that the edit action is taking place in a different row from
where they clicked. Comments are especially welcomed on
this aspect of the interaction.
The original author of this patch is Owen Leonard <oleonard at myacpl.org>
Test Plan:
* Edit an existing circulation rule
* Delete a circulation rule
* Create a new circulation rule
* Create a new circulation rule that is a dup of an old one
and make sure that it still overwrites the old rule like before
Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
All tests passed.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Comments on last patch.
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
-----------------------------------------------------------------------
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list