[koha-commits] main Koha release repository branch new/bug_9484 created. v3.12.00-beta1-97-g04d346e

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_9484 has been created
        at  04d346ecca42ce31ad7aebd5eba9a501efa12f1f (commit)

- Log -----------------------------------------------------------------
commit 04d346ecca42ce31ad7aebd5eba9a501efa12f1f
Author: Adrien Saurat <adrien.saurat at biblibre.com>
Date:   Thu Jan 24 17:11:31 2013 +0100

    Bug 9484: userid not generated consistently (different editing pages)
    
    When modifying a patron through different pages, the userid
    generation does not behave always the same way; this patch
    corrects this:
    - when firstname and surname are present in the form, they
    are used for the generation;
    - if there are not in the form, the firstname and surname
    in database are used instead.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    
    Comment: Work as described. No errors.
    Test
    This patch lacks a test plan, so I do the following
    1) New user, empty userid, autocompleted
    2) Edit user, change userid, saved correctly
    3) Edit user, main edit window, emptied userid, autocompleted
    4) Edit user, Detail > Library use, emptied userid, not autocomplete (not even a dot)
    5) Applied patch
    6) Repeated 1-3, same behavior
    7) Repeated 4), now autocompletes with same userid as 3)
    
    So, works as described.
    No koha-qa errors.
    
    NOTE: It's impossible now to delete userid from interface.
    
    Off-topic: tried an userid in Arabic, works very well.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit 1626e779177b720c150dffe0138ce04070276219
Merge: e994b36 58ef8fe
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Sat Mar 30 21:39:46 2013 -0400

    Merge branch 'bug_9885' into 3.12-master

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository