[koha-commits] main Koha release repository branch new/bug_8264 created. v3.12.00-beta1-379-g898e8f1

Git repo owner gitmaster at git.koha-community.org
Wed May 1 12:15:35 CEST 2013

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_8264 has been created
        at  898e8f131c53d3447359b3752475e96ba46dfb67 (commit)

- Log -----------------------------------------------------------------
commit 898e8f131c53d3447359b3752475e96ba46dfb67
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Wed May 1 06:20:00 2013 -0400

    Add Edmund Balnaves to history
    Welcome, Edmund. You are the 210th committer to Koha!

commit 7e293e20de5cf5639c161b46871f401ab950e841
Author: Edmund Balnaves <ejb at prosentient.com.au>
Date:   Mon Apr 15 11:08:06 2013 +1000

    Bug 8264 - local cover images not working in IE8 [ prog ]
    [Patch submitted by David Cook]
    Edmund, rather than myself, was the author of this patch,
    so I'm not entirely sure about his code choices, but...it
    looks like IE must process images differently than other
    It seems to me that the images are not appearing in IE,
    because they're being regarded as incomplete or having
    0/NULL natural width.
    This patch simply introduces a try/catch hack where it
    tries to add the image and remove any "no-image" elements
    even nwhen the image is considered incomplete/width of
    0/NULL. It won't do this if it catches any errors,
    although I'm not sure that any errors would be caught
    with this set up anyway...
    It's certainly not the ideal solution, but it's a solution.
    To Test:
    Before applying the patch:
    1) Use IE and FF/Chrome/other browser to view a record
       with local images attached
    2) Note that the local images appear in FF/Chrome/other,
       but not in IE
    Apply patch.
    After applying the patch:
    1) Repeat step 1 from above
    2) Note that the local images now appear in all browsers
       as they should.
    As I mentioned before, this seems like a real suboptimal
    solution. Any ideas on why IE might be considering local
    images to be incomplete or having 0/NULL natural width?
    Signed-off-by: David Cook <dcook at prosentient.com.au>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    I did a regression test using Chromium and Firefox in
    Ubuntu. I checked both prog and CCSR - covers displayed
    All tests and QA script pass.
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
    Changed author of patch to reflect actual authorship.


main Koha release repository

More information about the koha-commits mailing list