[koha-commits] main Koha release repository branch new/bug_10033 created. v3.12.00-beta1-427-g598dfe2

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_10033 has been created
        at  598dfe27224f517fafa06df75521c623992ecbe0 (commit)

- Log -----------------------------------------------------------------
commit 598dfe27224f517fafa06df75521c623992ecbe0
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Fri Apr 12 17:24:17 2013 +0200

    Bug 10033 - dangerous query in _koha_modify_item
    
    The SQL query build in C4::Items::_koha_modify_item performs an update on a row of items table identified by itemnumber.
    Actually the query is build using a hash of datas :
        for my $key ( keys %$item ) {
            $query.="$key=?,";
            push @bind, $item->{$key};
        }
    But this hash contains 'itemnumber' key, so you get an update including the primary key.
    It is actually harmless but may be dangerous.
    
    This patch simply skips itemnumber key in above loop.
    
    Test plan :
    Check you can create and modify items.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit b7d0c50487bb6388b9d90a8ea71313730af931d9
Merge: f7644ec d098a7c
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Wed May 1 08:15:00 2013 -0400

    Merge branch 'bug_8419' into 3.14-master

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository