[koha-commits] main Koha release repository branch new/bug_6506 created. v3.12.00-beta1-433-g79ea900
Git repo owner
gitmaster at git.koha-community.org
Wed May 1 14:38:07 CEST 2013
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, new/bug_6506 has been created
at 79ea900b2c47caa71e995fa35d65e1a5c78d3a6d (commit)
- Log -----------------------------------------------------------------
commit 79ea900b2c47caa71e995fa35d65e1a5c78d3a6d
Author: Peter Crellan Kelly <peter at catalyst.net.nz>
Date: Wed Apr 10 07:22:41 2013 +1200
Bug 6506: Correct CSS class name.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
http://bugs.koha-community.org/show_bug.cgi?id=6509
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 571dab9c7cd7f79e936c28fa60d471e6c1288493
Author: Peter Crellan Kelly <peter at catalyst.net.nz>
Date: Thu Mar 28 21:00:47 2013 +1300
Bug 6506: When AnonymousPatron not set, deletion of issue history silently failed.
Remedied by:
- in Circulation.pm changing AnonymiseIssueHistory so that it returns ($rows, $err_history_not_deleted) instead of $rows
- consequential change to misc/cronjobs/batch_anonymise.pl to handle updated return value, and fail if there is an error
- consequential change to tools/cleanborrowers.pl although this still fails silently (raised as bug 9944)
- update of opac-privacy.pl to check return value and pass on error
- update of opac-privacy.tt to display error if appropriate
Note bug 9942 remains unfixed, which is a similar issue upon issue return.
To test:
1. OPAC
- enable privacy mode (preference OpacPrivacy)
- leave anonymous patron set to zero (preference AnonymousPatron)
- attempt to delete user history
- observe error
- check history - still there
- change anonymous patron to a valid user
- attempt to delete user history
- observe success message
- check history - gone
2. cleanborrowers.pl
- test it functions as before. bug 9944 has been raised for it continuing to silently fail.
3. batch_anonymise.pl
- enable privacy mode (preference OpacPrivacy)
- leave anonymous patron set to zero (preference AnonymousPatron)
- run script (I use --days -1 for testing)
- script should fail with a Carp message
- change anonymous patron to a valid user
- run script as before
- script returns quietly
- check history - gone
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 4c709c600799392eae67f715cff1b5a2e574c042
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Tue Apr 9 12:08:56 2013 +0200
Bug 6506: Followup add warning in the system information tab.
Add a warning in the system information tab of the about page.
Test plan:
Set OPACPrivacy = 1 and AnonymousPatron = 0 and go on the about page,
tab 'system information'. Check that the warning appears.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
http://bugs.koha-community.org/show_bug.cgi?id=6509
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
commit 59baea315a63f23606c70d1f551512bf13096406
Merge: 4563f7b 3269d35
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Wed May 1 08:22:39 2013 -0400
Merge branch 'bug_7228' into 3.14-master
-----------------------------------------------------------------------
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list