[koha-commits] main Koha release repository branch new/bug_10166 created. v3.12.00-beta1-468-g5c95223

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_10166 has been created
        at  5c9522382c83f078692051fa572c56b21b54fa77 (commit)

- Log -----------------------------------------------------------------
commit 5c9522382c83f078692051fa572c56b21b54fa77
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Mon May 6 08:35:00 2013 -0400

    Bug 10166: Increment holdable counter
    
    The $anyholdable variable was set to 0 or 1. However, as it is set in
    a loop, and future changes to the opac-reserve.pl script may require
    knowing how many items the patron is going to place a hold on, it makes
    more sense to treat $anyholdable as a counter. This follow up turns it
    into one.
    
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit 8016d2bd0d2d45ee0777469d28d988f2794575fb
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed May 1 14:22:50 2013 -0400

    Bug 10166 - Can't place holds on multiple titles if one or more are un-holdable
    
    opac-reserve.pl tries to check whether all selected titles in a
    multiple-hold batch are unavailable to be placed on hold. However, the
    logic is flawed in such a way that if the last item in the batch cannot
    be placed on hold the script assumes none can be placed on hold.
    
    This patch modifies the way the script tracks the "no titles available
    for holds" variable in order to correct the error.
    
    To test, place multiple holds by selecting titles from a list of search
    results. Test three conditions:
    
    - All titles are available to be placed on hold
    
      You should see no onscreen warnings, and all titles should be
      selectable on the place hold screen. A "Place hold" button should
      appear at the bottom.
    
    - Some titles can be placed on hold, some cannot
    
      The titles which can be placed on hold should be selectable.
      Titles which cannot be placed on hold should show a warning
      message. A "Place hold" button should appear at the bottom.
    
    - No titles can be placed on hold
    
      "Sorry, none of these items can be placed on hold." should appear at
      the top of the page. All titles should appear with warning messages.
      There should be no "Place hold" button.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    All tests and QA script pass.
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit 539aa7ddb44a81f793e98d79284714aab274b810
Merge: d815a83 d485dbe
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Mon May 6 08:24:59 2013 -0400

    Merge branch 'bug_10183' into 3.14-master

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository