[koha-commits] main Koha release repository branch 3.8.x updated. v3.08.12-13-gd1a8452

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.8.x has been updated
       via  d1a845261c43188e5d8923b7635c3422f06b0fd8 (commit)
       via  2247bf6907ee6fb90e614c83e2932d018925a9a9 (commit)
      from  2d79c840351885f670432b6453d1734ac21fcd6c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d1a845261c43188e5d8923b7635c3422f06b0fd8
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Wed Apr 10 12:37:54 2013 +0200

    Bug 10022 - Multiple tags moderation doesn't work on translated page
    
    When using a translated intranet, tags moderation using checkboxes and a
    submit button doesn't work. You get a message "Unknown Operation on x
    Term(s)" (translated of course).
    
    This patch corrects by using name="op-[operation]" instead of name="op"
    in each submit input.
    
    Test plan :
    - Create a new tag on a record
    - Go to tags moderation in Tools
    => You should see your tag in pending terms
    - Click on checkbox
    - Click on Approve or Reject submit button at the bottom of the table
    => Without patch the tag is still pending
    => With patch operation is well performed, tag is not pending
    - Test "Check lists" form
    - Test Approve and Reject buttons from "Actions" column
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

commit 2247bf6907ee6fb90e614c83e2932d018925a9a9
Author: Edmund Balnaves <ejb at prosentient.com.au>
Date:   Mon Apr 15 11:08:06 2013 +1000

    Bug 8264 - local cover images not working in IE8 [ prog ]
    
    [Patch submitted by David Cook]
    Edmund, rather than myself, was the author of this patch,
    so I'm not entirely sure about his code choices, but...it
    looks like IE must process images differently than other
    browsers.
    
    It seems to me that the images are not appearing in IE,
    because they're being regarded as incomplete or having
    0/NULL natural width.
    
    This patch simply introduces a try/catch hack where it
    tries to add the image and remove any "no-image" elements
    even nwhen the image is considered incomplete/width of
    0/NULL. It won't do this if it catches any errors,
    although I'm not sure that any errors would be caught
    with this set up anyway...
    
    It's certainly not the ideal solution, but it's a solution.
    
    To Test:
    
    Before applying the patch:
    1) Use IE and FF/Chrome/other browser to view a record
       with local images attached
    2) Note that the local images appear in FF/Chrome/other,
       but not in IE
    
    Apply patch.
    
    After applying the patch:
    1) Repeat step 1 from above
    2) Note that the local images now appear in all browsers
       as they should.
    
    --
    
    As I mentioned before, this seems like a real suboptimal
    solution. Any ideas on why IE might be considering local
    images to be incomplete or having 0/NULL natural width?
    
    Signed-off-by: David Cook <dcook at prosentient.com.au>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    I did a regression test using Chromium and Firefox in
    Ubuntu. I checked both prog and CCSR - covers displayed
    nicely.
    All tests and QA script pass.
    
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
    Changed author of patch to reflect actual authorship.
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/js/localcovers.js  |    7 +++++++
 .../intranet-tmpl/prog/en/modules/tags/review.tt   |    6 +++---
 koha-tmpl/opac-tmpl/prog/en/js/localcovers.js      |    7 +++++++
 tags/review.pl                                     |    7 ++++++-
 4 files changed, 23 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository