[koha-commits] main Koha release repository branch new/bug_10185 created. v3.12.00-beta1-489-g30d0674

Git repo owner gitmaster at git.koha-community.org
Wed May 8 15:54:09 CEST 2013

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_10185 has been created
        at  30d067400e6d15cd86d8b35daed4bb10438d0e2e (commit)

- Log -----------------------------------------------------------------
commit 30d067400e6d15cd86d8b35daed4bb10438d0e2e
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Mon May 6 06:43:50 2013 +0000

    Bug 10185: Add missing columns in update
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    SQL only changes fixing an important database update.
    IMPORTANT: Patches must be backported to all versions containing
    the database update
    I used the test plan provided by Julian with some additions:
    1/ Do a fresh 3.8 install
    2/ Do some reserves
    3/ Check your old_reserves table is empty
    4/ Update your sources to 3.10
    5/ Run updatedatabase.pl
    6/ Your reserves table is now empty!
    I made sure I had item level and title level holds, also
    suspended holds.
    I repeated the test with entries in my old_reserves table
    (cancelled and filled holds) to make sure this is also still
    working correctly.
    Before the patch we lost all suspended holds and when the
    old_reserves table was empty also all holds in general.
    After the patch the reserve_id is added but the other data
    in both tables is not altered.
    NOTE: Adding the reserve_id first to old_reserves and then
    to reserves we are missing one id in between.
    old_reserves: 1,2,3
    reserves: 5,6
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit 37c52367b08f30514483b02a387cb5a463ea15d0
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Fri May 3 17:20:17 2013 +0200

    Bug 10185: Fix update
    It can remove all reserves from reserves table when there is no entries
    in old_reserves.
    This is due to @ai which is set to NULL in
      SET @ai = ( SELECT MAX( reserve_id ) FROM tmp_reserves )
    and reserve_id > NULL returns no results in
      INSERT INTO reserves SELECT * FROM tmp_reserves WHERE reserve_id > @ai
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Test plan and comments on second patch.
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit 4bd9406309933be5c6a5a9dcee651978a42ba8fb
Merge: a167834 2e103a0
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Wed May 8 09:52:28 2013 -0400

    Merge branch 'bug_10156' into 3.14-master


main Koha release repository

More information about the koha-commits mailing list