[koha-commits] main Koha release repository branch new/bug_10054 created. v3.12.00-beta1-505-g218194f

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_10054 has been created
        at  218194fab0398e433651d5ba26634d79c63442f5 (commit)

- Log -----------------------------------------------------------------
commit 218194fab0398e433651d5ba26634d79c63442f5
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Mon Apr 15 09:09:05 2013 -0400

    Bug 10054 - When SingleBranchMode is enabled, allow superlibrarians to set logged in library
    
    Currently, when SingleBranchMode is enabled, nobody can change the
    logged in library in Koha. To change it requires disable
    SingleBranchMode, switching the library, and re-enabling it. It seems
    reasonable to allow superlibrarians to switch the logged in library even
    if SingleBranchMode is enabled.
    
    Test Plan:
    1) Apply this patch
    3) Enable SingleBranchMode
    4) Log in as a superlibrarian
    5) Attempt to change the logged in branch
       This change should succeed
    6) Log in as a non-superlibrarian account
    7) Attempt to change the logged n branch
       This should not be allowed, as per Koha's current behavior
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    I guess this doesn't do any harm even though the practical motivations
    behind it, as described in the bug, seem otherwise solvable. If
    SingleBranchMode is supposed to prevent librarians from switching their
    logged in library why can they choose their library when they first log
    in? Was SingleBranchMode supposed to only affect the OPAC originally? Or
    should the login form be modified? This seems to be a band-aid on a
    poorly-implemented feature.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Patch works as decribed. As this only adds a check for a superlibrarian
    it seems safe and should not interfere with normal staff accounts.
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit a935e1b1e9cba96c7e47835e11aeb665c747dbd6
Merge: 5ab2f83 b36d3bc
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Sun May 12 10:09:38 2013 -0400

    Merge branch 'bug_10225' into 3.14-master

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository