[koha-commits] main Koha release repository branch new/bug_10030 created. v3.12.00-beta1-539-g656aba3

Git repo owner gitmaster at git.koha-community.org
Thu May 16 03:44:58 CEST 2013

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_10030 has been created
        at  656aba3e1ff1a2eb69baf9bbab38cf4b37b38afe (commit)

- Log -----------------------------------------------------------------
commit 656aba3e1ff1a2eb69baf9bbab38cf4b37b38afe
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed May 15 16:06:49 2013 +0200

    Bug 10030: QA Followup for trivial false warning detected while testing
    Moving the warn line below the line that returns if amount<=0.
    If amount<=0, a false warn is now raised because of the return after it.
    We should only warn here if we do not return.
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Tested with fines.pl on overdue.
    Before this patch:
    Reducing fine for item 199709 borrower 23 from 44 to -1 - MaxFine reached.
    This did not happen however because of the return.
    After this change: no false warning.
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit 9fc4c64140640df25b7a6519226d3d097bd9b72c
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Apr 11 15:46:50 2013 -0400

    Bug 10030 - MaxFines checks against amount, not amount outstanding
    If a patron has over time accumulated fines greater than the amount
    defined in MaxFine, the patron will never get more fines even if they
    have previously paid off those fines.
    This bug was introduced by the patch for Bug 7420.
    Test Plan:
    1) Create a patron
    2) Create a fine of 10.00 for that patron
    3) Pay off the fine
    4) Set MaxFines to 5.00
    5) Check out an item to the patron, backdate the due date
       so the item should generate fines.
    6) Run fines.pl, observe that no fine was created
    7) Apply the patch
    8) Rerun fines.pl
    9) Observe that the fine was created correctly
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>


main Koha release repository

More information about the koha-commits mailing list