[koha-commits] main Koha release repository branch new/bug_10281 created. v3.12.00-beta1-558-gcd281e4

Git repo owner gitmaster at git.koha-community.org
Sun May 19 14:32:21 CEST 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_10281 has been created
        at  cd281e488032c57d4a47c3913d5f887c3bca69d8 (commit)

- Log -----------------------------------------------------------------
commit cd281e488032c57d4a47c3913d5f887c3bca69d8
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Sat May 18 09:09:23 2013 -0400

    Bug 10281: searching for a search domain fails
    
    For reasons I cannot fathom, the split() in handling multi-branch
    limits was not coming up with a valid search group code. Replacing
    the split() with a substr() and creating the CGI parameter as a string
    rather than as an arrayref fixes the problem. This problem may not
    affect all installations, since I tested this exact feature just under
    two months ago and it worked fine, and none of the relevant code has
    been changed since then that I can see.
    
    To test:
    1) Create search group, and add at least one library to it, in
       /cgi-bin/koha/admin/branches.pl
    2) Apply patch
    3) Try doing a search limited to your search group, making sure that
       the search will match items that belong to a library in the search
       group
    4) Sign off
    
    Signed-off-by: Magnus Enger <magnus at enger.priv.no>
    I have failed to recreate the problem on three different dev installs,
    both on Ubuntu and Debian, but the current patch does not break
    anything as far as I can tell, so I'm signing off.
    
    I tested with two libraries in the same search domain, with each
    library owning a different book by the same author. Searching for
    the author in
    - all libraries,
    - individual libraries and
    - the search domain that contains both libraries
    all return the expected results.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    All tests and QA script pass.
    I couldn't reproduce the problem, but didn't find any regressions.
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit 0e6a2440a0d16b6248fcdac7b66d0c2b938a8078
Merge: f04b9ec 26a4b33
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Sun May 19 08:38:40 2013 -0400

    Merge branch 'bug_9452' into 3.14-master

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list