[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-639-g040eb40

Git repo owner gitmaster at git.koha-community.org
Tue May 28 17:24:21 CEST 2013

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  040eb4016f4b01d44f87ab6aca515c6917f73479 (commit)
      from  45168efeb9a2c6e3268e2f002ca31af8e5e6afc8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 040eb4016f4b01d44f87ab6aca515c6917f73479
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu May 16 14:02:24 2013 -0400

    Bug 10262 - fine calculation at checkin not respecting CircControl
    The fines.pl script uses the system preference CircControl to decide
    what branches circ rules to use for fine generation.
    Recently, code was added to the returns system to recalculate the fine
    at checkin time ( to support hourly loans ). The problem is that this
    code does not respect CircControl.
    Test Plan:
    1) Set circ control to "the library you are logged in at"
    2) Set different fines rules for two different librarys
    3) Check an item out at library A, backdate the due date so it's overdue
       and will have fines.
    4) Check the item in at library B
    5) Observe that the fines should be generated based on library A's rules,
       but the fines will be based on library B's rules instead!
    5) Apply the patch
    6) Repeat steps 3 and 4.
    7) Observe now that the fines should reflect the fines rules for Library A
    Note: it seems counter-intuitive for the fines system to behave this way
    based on the preference being set to "the library you are logged in at"
    but it does make sense. The rules used are from "the library you are
    logged in at" when the item is first checked out.
    If the fines system really did use the rules for the library the item was
    returned to, it would be easy to exploit the library system. Some Koha
    using systems have branches that charge fines, and others that don't, so
    a patron could just return any overdue items to a non-charging branch
    to avoid ever paying fines!
    Furthermore, it would mean that the fines.pl script would be using one
    set of rules to charge fines, and the returns system could possibly be
    using another. Since fines.pl has been around far longer, it makes sense
    to assume the fines.pl behavior is canonical.
    Signed-off-by: Mickey Coalwell <mcoalwell at nekls.org>
    Signed-off-by: George Williams <georgew at latahlibrary.org>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Merged with reservations; see comment on bug report for details.


Summary of changes:
 C4/Circulation.pm |   37 ++++++++++++++++++++++++++-----------
 1 files changed, 26 insertions(+), 11 deletions(-)

main Koha release repository

More information about the koha-commits mailing list