[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-645-ge294def

Git repo owner gitmaster at git.koha-community.org
Thu May 30 16:04:52 CEST 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  e294defc299e97fe5e1ecfdeb648e8f8f080f5f5 (commit)
      from  a90a72c62dcfcbb1989d5ea60a80f51bcee8a23d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e294defc299e97fe5e1ecfdeb648e8f8f080f5f5
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Wed Jan 30 08:50:23 2013 +0000

    bug 9505 refactor loops in invoices.pl
    
    - Remove an unnecessary loop where output just
      recreated input.
    - Remove unnecessary temp variables that obscure code purpose.
    - Call the variable containing invoices, invoices
      rather than anonymous and ambiguous results
      reflect namechange in template.
    - Lists are passed to template as array refs;
      declare them as scalars as that is how we use them.
    - No need to introduce the whole namespace of some C4
      modules for 1 routine.
    
    Test plan:
    
    Note that this patch should not change any visible behavior.
    
    [1] Open the invoice search page.
    [2] Verify that the list of suppliers in the drop-down
        on the search form is complete.
    [3] Verify that the list of libraries in the drop-down
        on the saerch form is complete.
    [4] Perform a search.  Verify that the list of invoices
        is correct.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 acqui/invoices.pl                                  |   94 ++++++++-----------
 .../prog/en/modules/acqui/invoices.tt              |   32 ++++----
 2 files changed, 56 insertions(+), 70 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list