[koha-commits] main Koha release repository branch 3.12.x updated. v3.12.06-12-g63fa185

Git repo owner gitmaster at git.koha-community.org
Wed Nov 6 17:27:34 CET 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.12.x has been updated
       via  63fa18513fceb8fee6b6a35d885ec50b0d55c969 (commit)
       via  4bc27151a1cb5a50825fc739e8ccf84aef913afb (commit)
      from  a89124f7b0ee3e53f1e1462c13bb492e23f4127c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 63fa18513fceb8fee6b6a35d885ec50b0d55c969
Author: Magnus Enger <magnus at enger.priv.no>
Date:   Sat Aug 31 15:33:24 2013 +0200

    Bug 10810 - Fix synopsis for -html option to overdue_notices.pl
    
    The synopsis for the -html option used to be:
      -html <filename> Output html to file
    but the argument to this option should actually be a directory,
    not a filename. This patch fixes the synopsis.
    
    To test:
    - Run perldoc misc/cronjobs/overdue_notices.pl
    - Check that the synopsis is as shown above
    - Apply this patch
    - Run perldoc misc/cronjobs/overdue_notices.pl
    - Check that
      - the synopsis asks for a directory, not a filename
      - that the description of the -html option further down in the
        perldoc now mentions the filename that the HTML file will be
        created with.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Works as described. No koha-qa errors.
    
    If feeded with a filename -html option fails with many messages like
    print() on closed filehandle $html_fh at misc/cronjobs/overdue_notices.pl line 384.
    Perhaps it could be improved, but that was the old behavior.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Improves documentation, no negative side effects found.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit b54e33c1f62e4aa2c7e46a7fafa445f33f570326)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 4bc27151a1cb5a50825fc739e8ccf84aef913afb
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Tue Aug 13 14:55:32 2013 +0200

    Bug 10718: fix items with no checkouts report
    
    Bug 8124 has commented the option to download results items with no
    checkouts report into a file.  But the perl code of this page uses
    the export into a file has default behavior since the input "output"
    is no more present.  The consequence is that there are never results
    in page.
    
    This patch removes the code concerning file output from template and perl.
    Such a feature exists in guided reports.
    
    Test plan :
    Play with cgi-bin/koha/reports/catalogue_out.pl form and see if you get results
    
    Bug 10718 - select user branch as default
    
    In cgi-bin/koha/reports/catalogue_out.pl report, select in library filter the user logged-in.
    
    Test plan :
    - Log into intranet with a normal user
    - Got to "Items with no checkouts" reports
    => Your branch is selected
    - Run report
    => You see "Filtered on : Branch = <your branch>"
    - Come back to report
    - Select "Any library"
    - Run report
    => You do not see "Filtered on : Branch"
    
    Bug 10718 - items with no checkouts report permission is execute_reports
    
    This report only executes SQL to change reports/catalogue_out.pl permissions from all reports subpermissions to reports/execute_reports.
    
    Test plan :
    Test you can access and run this report with only execute_reports subpermission into reports permission.
    
    Bug 10718 - redefine limit input
    
    In reports/catalogue_out.pl form, the limit input is by defaut none.
    So by default the report queries all the catalogue.
    This may take a very long time (fall into timeout) and since now the results are displayed in page, the page may be huge.
    
    This patch modifies limit input to removes the "none" option.
    Also reduces the number of options (same options as guided reports results per page).
    
    Test plan:
    - Go to reports/catalogue_out.pl
    => first value "10" is selected
    - Launch report
    => You see "Filtered on: limit = 10"
    
    Bug 10718 - perltidy on reports/catalogue_out.pl
    
    Signed-off-by: Liz Rea <liz at catalyst.net.nz>
    Tested all of these things, all ok - squashed patch for neatness.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.
    Fixed a tab in one of the comments.
    Improves script, but more work needed.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit ec09fe092e302dfbaf8ddf2a26ab361be9ea915e)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 .../prog/en/modules/reports/catalogue_out.tt       |   53 ++--
 misc/cronjobs/overdue_notices.pl                   |    4 +-
 reports/catalogue_out.pl                           |  330 +++++++++-----------
 3 files changed, 174 insertions(+), 213 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list