[koha-commits] main Koha release repository branch 3.12.x updated. v3.12.06-24-ga461452

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.12.x has been updated
       via  a461452de234fcdd3d08974c9f0b9b03772710f3 (commit)
       via  4565a96085717914995727336a91888362353754 (commit)
       via  cb988890cdc14401dff12b57a79c6e7646b153b9 (commit)
       via  453a9ccae270001394cef697bb922614b152e4ba (commit)
       via  1f9c3c90a66c02872ca7ed260bfdb7945ad8896b (commit)
      from  b178a758a2b3a6b7ee1c0b5beaf3460daf0057d2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a461452de234fcdd3d08974c9f0b9b03772710f3
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Tue Sep 17 16:35:57 2013 +0000

    Bug 10897: remove test for module that has become DB-dependent
    
    This is an alternative appraoch to fixing this bug; as the
    compilation test for C4::ILSDI::Services also resides
    in t/db_dependent/ILSDI_Services.t, we don't need t/ILSDI_Services.t
    at present.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit dcbe50cde84505198dffbd1a65d998287f0902dc)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 4565a96085717914995727336a91888362353754
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Mon Sep 16 19:22:22 2013 +0000

    Bug 10667: (follow-up) fix reference to UT library in test case
    
    This patch prevents a spurious test case failure if the
    test database happens to already have a library whose
    code is 'UT'.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 2a8481a5e2f487c649fc9b2e1c03b42fe42fee07)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit cb988890cdc14401dff12b57a79c6e7646b153b9
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date:   Thu Sep 12 07:36:24 2013 +0200

    Bug 10667: Follow up - prevent t/00-load from failing
    
    To test:
    - Apply first 2 patches for unit tests and changes to Services.pm
    - Turn off mysql
    - Run t/00-load.t
    - Verify that the test fails.
    - Apply this third patch.
    - Run t/00-load.t again.
    - Verify this time it passes.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Comment: Work well, no koha-qa errors.
    
    Without third patch and mysql down, test fails,
    with third patch it succeed.
    Signed-off-by: Mason James <mtj at kohaaloha.com>
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 8e0c21cf38b930c207d2efab4a3b55e359b95b89)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 453a9ccae270001394cef697bb922614b152e4ba
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date:   Sun Sep 8 21:42:04 2013 +0200

    Bug 10667: Allow authentication with cardnumber for ILS-DI
    
    Test authentication via ILS-DI:
    - with userid and password
    - with userid and wrong password
    - with cardnumber and password
    - with cardnumber and wrong password
    ...
    
    Before the patch only userid will authenticate the patron.
    After the patch was applied, userid and cardnumber will work.
    
    To test:
    - Run t/db_dependent/ILSDI_Services.t - all tests should pass.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    No koha-qa errors
    
    Test:
    Enable ISL-DI
    access opac with /cgi-bin/koha/ilsdi.pl?service=AuthenticatePatron&username=XXX&password=YYY
    With userid/cardnumber & password returns borrowernumber
    With userid/cardnumber & wrong password returns PatronNotFound
    Signed-off-by: Mason James <mtj at kohaaloha.com>
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit ddb67e32377185df371c85172308be882968b14f)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 1f9c3c90a66c02872ca7ed260bfdb7945ad8896b
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date:   Sun Sep 8 21:34:37 2013 +0200

    Bug 10667: Add unit tests for ILSDI::Services::AuthenticatePatron
    
    This patch adds unit tests for Authenticate patron.
    
    To test:
    - Run perl t/db_dependent/ILSDI_Services.t
    - Verify all tests pass
    
    Note: there are some tests marked as TODO.
    
    Rewriting AuthenticatePatron to make cardnumber and userid
    work for authenticating a patron will be implemented in the
    next patch. Tests related to this are currently showing as
    'not ok', but are still passing.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    No koha-qa errors
    With both patches applied, all test pass.
    Signed-off-by: Mason James <mtj at kohaaloha.com>
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 995f4b6ecb504e1648816b0841e90efb814f25c7)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/ILSDI/Services.pm                         |   25 +++----
 koha-tmpl/opac-tmpl/prog/en/modules/ilsdi.tt |    2 +-
 t/00-load.t                                  |    1 +
 t/ILSDI_Services.t                           |   14 ----
 t/db_dependent/ILSDI_Services.t              |   92 ++++++++++++++++++++++++++
 5 files changed, 105 insertions(+), 29 deletions(-)
 delete mode 100755 t/ILSDI_Services.t
 create mode 100644 t/db_dependent/ILSDI_Services.t


hooks/post-receive
-- 
main Koha release repository