[koha-commits] main Koha release repository branch 3.12.x updated. v3.12.06-59-g748c14e

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.12.x has been updated
       via  748c14eac169612a60f056c2b7ec6511267ff29d (commit)
       via  0aa2a4346c69dbf0a68e004825254220886ef42a (commit)
       via  76901e1bfec59a02b1d1dce0550521af107e9bc8 (commit)
       via  361bc49390e63b451396584236ff7859d511613d (commit)
      from  6aea4e075bcadb80d4159e25980d88ae0547240a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 748c14eac169612a60f056c2b7ec6511267ff29d
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Fri Nov 8 16:21:26 2013 +0000

    Bug 11218: (follow-up) fix whitespace
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 87470f394aa58e7ea1d89cadffc8d724b433cd80)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 0aa2a4346c69dbf0a68e004825254220886ef42a
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date:   Fri Nov 8 08:33:29 2013 +0100

    Bug 11218: (follow-up) fix some whitespace and a variable declaration
    
    Fixing some things the QA script pointed out this morning:
    
    - whitespace
    - variable declaration
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 1528a6deda468dc4a7391ea7a9fff60c57af314f)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 76901e1bfec59a02b1d1dce0550521af107e9bc8
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date:   Fri Nov 8 00:31:09 2013 +0100

    Bug 11218: fix Item Due notices not being generated
    
    To test:
    - Check out at least 3 items, due dates should be today, sometime in
      the past and one day after tomorrow.
    - Edit the message options - activate DUE and PREDUE notices with
      days in advance = 2
    - Run the advance_notices.pl script with -v -c
      Result: Only a PREDUE notice is generated
    - Run the advance_notices.pl script with -v -c -m 2
      Result: Only the PREDUE message is generated correctly.
    - Run t/db_dependent/Circulation.t
      - without first patch: all tests pass.
      - with first patch: some tests will fail.
    - Apply patch.
    - Rerun script, now PREDUE and DUE notices should be
      generated.
    - Run t/db_dependent/Circulation.t again, all tests should pass.
    
    Add more items with different due dates, rerun and check results.
    
    Run t/Circulation.t to confirm all tests pass.
    - Apply the patch
    
    Signed-off-by: Liz Rea <liz at catalyst.net.nz>
    Passes functional tests and automated tests.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit a8bc7c9ef8222d0c9292ff5a93f3ecb8d68a2eed)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 361bc49390e63b451396584236ff7859d511613d
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date:   Fri Nov 8 00:26:45 2013 +0100

    Bug 11218: Regression tests for Due notice generation
    
    Changes tests for GetUpcomingDueIssues:
    
    days_in_advance should be inclusive:
     2 should find items due in 2 days from now.
     1 should find items due tomorrow.
     0 should only find items due today.
    
    Adds new tests for Bug 11218:
    
    As the advance_notices.pl, the only script using GetUpcomingDueIssues
    is not only used for PREDUE notices, but also for
    DUE notices, we need to also select items due today.
    
    Signed-off-by: Liz Rea <liz at catalyst.net.nz>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    Rebased for 3.12.x

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm            |    2 +-
 t/db_dependent/Circulation.t |   88 +++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 88 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository