[koha-commits] main Koha release repository branch 3.12.x updated. v3.12.06-71-gda14438

Wed Nov 20 16:18:45 CET 2013

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.12.x has been updated
       via  da1443882cef1e02e9fc1a139bcbeb717519e507 (commit)
       via  6229c2b2db34d08dbf40fbf3f376bc836060aa93 (commit)
       via  0abefa6f760db048e2dce5eb8c6b20cc5a1ac4ab (commit)
       via  52e0b599fd9497dcc228ee5e21a729b4ffdbafb3 (commit)
       via  0e21efd76e3366267ee144b7ca317b855f292f2d (commit)
       via  acfcf68d8ea5344069fdefafa146456041e6b10d (commit)
      from  f4ae9bad32d3b1dd656cee84e28938b6613d3b8b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit da1443882cef1e02e9fc1a139bcbeb717519e507
Author: Sophie Meynieux <sophie.meynieux at biblibre.com>
Date:   Tue Aug 13 18:14:21 2013 +0200

    Bug 10720: fix issue that prevented use of HTML tags in overdue notices

    Substitution term in overdue notices shouldn't be removed if they don't match.
    It prevents use of HTML in notices to use with CSS.

    Test plan :
    - define an overdue notice containing some valid substitution terms + some valid html tags (<strong> or <div class="my class" to use with a css
    - find a borrower with overdues that trigger this notice
    - run overdue_notices.pl -html <directory>

    Without patch, your html tags are missing in your html file
    With the patch, they are present and can be used with a css to generate a formatted pdf file.

    If you add some invalid substitution term, with the patch, they are still in the final letter, but the warn in the log helps you to correct your notice template.

    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 394be84dcd65a4569d0467bc12b99dbd6341fc43)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 6229c2b2db34d08dbf40fbf3f376bc836060aa93
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Tue Oct 15 15:09:08 2013 +0100

    Bug 11054: Specify UTF-8 encoding when creating a child record

    When the only non-ascii characters in a new child record
    are latin + diacritic in the range covered by Latin-1 they
    are not being added to a new child record correctly encoded.
    Explicitly setting the record's encodiing ensures that
    they are interpreted correctly.

    see "Unicode Bug" in perldoc perlunicode for background on
    why these characters are special

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Works well. No koha-qa errors.

    Same test as before
    1) with a record with diacritics in author/title,
    2) press new child record, on new record 773adt
    with mangled accents
    3) Apply patch
    4) Repeat 2, now good results

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.
    Tested with a record containing umlauts in the title,
    $t was empty before and umlauts in $a mangled.
    After applying the patch fields are correctly filled and
    diacritics display correctly.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 8861c8dda545bddb3a4d28abce77c53c173e00d0)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 0abefa6f760db048e2dce5eb8c6b20cc5a1ac4ab
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Sun Oct 20 20:55:06 2013 +0000

    bug 10016: munge history in SCO to discourage resubmitting user login

    This patch uses history.replaceState (introduced in HTML5) to manipulate
    the browser history to encourage returning to the SCO patron barcode
    form if the back button is used.

    Note that a side effect of this patch is that if the user uses
    the help link, they will be prompted to enter their barcode
    again.  It may be better to put the help inline with the rest
    of the SCO forms.

    To test:

    [1] Start a web-based self-check session.
    [2] Enter a patron barcode.
    [3] Allow the self-check session to time out.
    [4] Use the back button.  You should get the patron barcode
        entry form; you should not be prompted to resubmit form input.
    [5] Enter a patron barcode, perform some transactions, then
        use the finish button.
    [6] Next, use the back button.  You should get the patron barcode
        entry form.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Ed Veal <ed.veal at bywatersolutions.com>
    Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 58d469ed4d6891cddf6a5ef35d21caa553dfb8ae)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    Deleted the sco-main.tt file for the bootstrap theme from the patch.

commit 52e0b599fd9497dcc228ee5e21a729b4ffdbafb3
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Sun Oct 20 17:13:22 2013 +0000

    Bug 10016: force zero browser-side caching of SCO pages

    This patch makes the web-based self-check module pages
    specify that no browser (or proxy caching) occur at all.
    This prevents a security issue where letting the SCO session time out,
    then hitting the back button allowed one to view the previous
    patron's session.

    This patch adds an optional fifth parameter to output_with_http_headers(),
    and output_html_with_http_headers(), a hashref for miscellaneous
    options.  One key is defined at the moment: force_no_caching, which if
    if present and set to a true value, sets HTTP headers to specify no
    browser caching of the page at all.

    To test:

    [1] Start a web-based self-check session and optionally perform
        some transactions.
    [2] Allow the session to time out (it may be helpful to set
        SelfCheckTimeout to a low value such as 10 seconds).
    [3] Hit the back button.  You should not see the previous patron's
        self-check session.
    [4] Verify that prove -v t/Output.t passes.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Ed Veal <ed.veal at bywatersolutions.com>
    Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 7b165794cd1875b79177f85db59be42a9708554a)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 0e21efd76e3366267ee144b7ca317b855f292f2d
Author: D Ruth Bavousett <druthb at gmail.com>
Date:   Sun Oct 20 12:23:44 2013 -0500

    Bug 8070: improve MARC preview display for RTL languages

    The Right Answer, according to the cataloger I spoke to,
    is to make it LTR when doing "raw" MARC display.

    To test:

    1) Install this patch, then run misc/translator/translate install ar-Arab
    2) search for a bib in the staff client.
    3) Switch to Arabic, and click the link to the left of "MARC Preview"

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    At first glace I was unsure about hard-coding this style in the
    template. Further testing indicated that this is required as the
    showmarc template doesn't inherit any of the CSS from the containing
    page.

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 432f5ad400c6679186b27a00b61a3ad72ddda313)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit acfcf68d8ea5344069fdefafa146456041e6b10d
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Mon Nov 18 19:04:56 2013 -0300

    Bug 11269: fix incorrect use of MARC::Field->subfield()

    MARC::Record 2.0.6+ enables the warnings pragma, and as a
    consequence, started logging cases where a routine in
    C4::Search was calling MARC::Field->subfield() with an undef
    subfield label.  This patch removes the log noise.

    To test:
    - Run prove -v t/db_dependent/Search.t
    - There will be warnings about
      "Use of uninitialized value $code_wanted in string" in MARC::Field.
    - Apply the patch.
    - Those warnings are gone.

    Signed-off-by: Liz Rea <liz at catalyst.net.nz>
    Tests now pass

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 2f6f6d2b0c4d4e8a4ed5ab17fbbf66393f8a2c69)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Output.pm                                       |   20 +++++++++++++-----
 C4/Search.pm                                       |    4 +++-
 cataloguing/addbiblio.pl                           |    1 +
 .../prog/en/modules/catalogue/showmarc.tt          |    2 +-
 .../opac-tmpl/prog/en/modules/sco/sco-main.tt      |   14 +++++++++++--
 misc/cronjobs/overdue_notices.pl                   |    2 --
 opac/sco/sco-main.pl                               |    2 +-
 t/Output.t                                         |   22 +++++++++++++++++++-
 8 files changed, 54 insertions(+), 13 deletions(-)

hooks/post-receive
-- 
main Koha release repository