[koha-commits] main Koha release repository branch master updated. v3.14.00-29-g248283f

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  248283fc29b46f59c56769a14f8d811cc61834ff (commit)
      from  2a4fa0a80307bf61a82a180220504c633000db7f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 248283fc29b46f59c56769a14f8d811cc61834ff
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Fri Oct 4 11:01:27 2013 +0100

    Bug 10996: Allow numeric subfields to be stripped on export
    
    Regex assumed all numeric characters were part of the tag number
    This is obviously false as $9 would be a likely candidate
    to be removed on export.
    
    The code can be any printing ascii character other than space
    according to LoC's website.
    
    Also changed regexp to no longer allow a zero length tag number
    which is nonsensical.
    
    The old regex would accept shorter than 3 digit tags but these were
    not stripped so I've removed that option, considering it a bug
    not a feature
    
    NB assumption that the code makes that a tag is always numeric is
    incorrect but works in practice. Handling non-numeric tags is
    a 'To be done'
    
    Made code dependent on the regex succeeding. Picking up results
    from a previous regex on failure can lead to weird hard to
    identify bugs
    
    In the course of testing Paola Rossi <paola.rossi at cineca.it>
    spotted that the delete operation was flawed, only removing
    the first occurence of the specified tag/tag subfield. Reworked
    the delete loop to operate on all occurences
    
    Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 tools/export.pl |   29 ++++++++++++++++-------------
 1 file changed, 16 insertions(+), 13 deletions(-)


hooks/post-receive
-- 
main Koha release repository