[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-1199-g88936cb

Git repo owner gitmaster at git.koha-community.org
Thu Oct 3 23:59:43 CEST 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  88936cb5245b854d5396d5bca0a9719a9a9bd1cc (commit)
       via  cf31604a0e4ba0f731f8fc8634007d1986e99f51 (commit)
       via  b90e1ff8927e7c621acbf2c12a1aeec05d84356b (commit)
       via  86c73e9b40491e5a8782dfbefd647272c0a58297 (commit)
       via  2a9c129d31e47908c8208291321e2d3f51de9ee7 (commit)
       via  b8a16ee2fc2a5c1a3a0939abb77c00b9e354bcc8 (commit)
       via  b9f74eaf416a8a7f7bcc62125783f1f887395abf (commit)
       via  497795f32ade45720f03cd4eae94311506a3b1e1 (commit)
       via  231ed790e4739af49c212568f90a105601035837 (commit)
      from  9db77158d09379504e171fb4c0f43e054b8940fd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 88936cb5245b854d5396d5bca0a9719a9a9bd1cc
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Thu Oct 3 22:13:40 2013 +0000

    bug 10419: (follow-up) improvements to the usage text
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit cf31604a0e4ba0f731f8fc8634007d1986e99f51
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Mon Sep 30 14:14:15 2013 +0200

    Bug 10419: (follow-up) patrons with fines should not be deleted
    
    Test plan:
    - add a fine for a patron
    - verify the script does not delete this patron.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Works, script do not delete a patron with fines.
    No koha-qa errors with all patches applied
    
    Test
    1) Added a fine to a patron
    2) run script
    3) reports condition
    Trying to delete patron 5... Failed to delete patron 5: patron has 10.00 in fines
    4) Patron is not deleted
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.
    
    Tested various combinations of options:
    ./delete_patrons.pl
      Gives a helpful message about the use of the script.
    ./delete_patrons.pl -h
      Outputs useful information about the use of the script
      and its various options.
    ./delete_patrons.pl --category_code ST --library CPL
      Gives the correct results in numbers and deletion was done
      properly.
    
    Also tested:
      --expired_before
      --not_borrowed_since
      -v
    
    Testing various conditions where a delete should not occur:
    - Patron has checkouts
      Patron is not in list of patrons to delete (x patrons to delete)
    - Patron has fines
      Patron is still in list of patrons to delete (x patrons to delete)
    
    Checked deleted patrons had been moved to deletedborrowers.
    
    Notes about possible enhancements:
    - only print the success message 'x patrons deleted' when confirm
      flag was set
    - patrons with current checkouts are silently excluded from the number
      of patrons to be deleted. Printing the number with current checkouts
      might be helpful.
    
    Changes made:
      Fixed a small error in the documentation: expired_date is expired_before.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit b90e1ff8927e7c621acbf2c12a1aeec05d84356b
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Tue Aug 13 12:47:14 2013 +0200

    Bug 10419: (follow-up) fix hardcoded records and pod
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Missing a sign. Removes harcoded values
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 86c73e9b40491e5a8782dfbefd647272c0a58297
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Tue Aug 6 15:38:24 2013 +0000

    Bug 10419: (follow-up) functional improvements
    
    [1] Patron deletion now happens atomically; if one part
        of the process fails, the record isn't left in a
        partially deleted state.
    [2] The routine for handling lists properly during patron
        deletion is now invoked.
    [3] The script now prints an indication if it's run
        without --confirm; otherwise, one might think that
        patron records were actually being deleted.
    [4] --verbose now actually does something.
    
    Without --verbose, the script will print the dry-run
    warning (if applicable), the number of patrons to be
    deleted, and error messages.
    
    With --verbose, the script will also print a line with
    the borrowernumber of each patron to be deleted.
    
    To test:
    
    [1] Run the script with and without --verbose and compare
        the, well, verbosity.
    [2] Run the script without --confirm and note that the script
        prints a message saying that it's running in dry-run mode.
    [3] Use the script to try to delete one or more patrons that have
        loans.  Confirm that error messages are printed reporting
        foreign constraints preventing the deletion.  Also confirm that
        no new rows are added to deletedborrowers for those patrons that
        could not be completely deleted.
    [4] Use the script to delete a patron that has a public list.  Verify
        that after the deletion, the public list still exists but now
        has a null owner.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 2a9c129d31e47908c8208291321e2d3f51de9ee7
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Tue Aug 6 15:05:26 2013 +0000

    Bug 10419: (follow-up) tidy names of command-line switches
    
    [1] Use --library instead of --branchcode to be consistent
        with other scripts and user-facing Koha terminology.
    [2] Use --not_borrowed_since instead of --not_borrowered_since;
        no need to expose typos in the API to the user.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit b8a16ee2fc2a5c1a3a0939abb77c00b9e354bcc8
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date:   Tue Aug 6 10:45:44 2013 +1200

    Bug 10419: (followup) fix license statement
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit b9f74eaf416a8a7f7bcc62125783f1f887395abf
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Mon Jul 15 09:28:40 2013 +0200

    Bug 10419: (follow-up) add branchcode parameter to patron deletion script
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 497795f32ade45720f03cd4eae94311506a3b1e1
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Fri Jun 7 15:51:43 2013 +0200

    Bug 10419: (followup) - tidy up cronjob for deleting patrons
    
    This followup adds:
    - execute flag (+x) for the cronjob script.
    - replaces --dry-run with --confirm (according with existing scripts).
    - changes output text (remove 'first person' style).
    - updates the doc and simplifies the dates parameters.
    - changes flags PrintError and RaiseError for the dbh in order to catch
      something if an error occurs...
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 231ed790e4739af49c212568f90a105601035837
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Jun 5 16:26:31 2013 +0200

    Bug 10419: new cronjob for deleting patrons
    
    This patch provides a cronjob script for deleting patrons.
    
    It takes 3 options:
    
    --not_borrowed_since
    --expired_date
    --category_code
    
    See the perldoc misc/cronjobs/delete_patrons.pl.
    Use the -v flag for a verbose mode.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 misc/cronjobs/delete_patrons.pl |  173 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 173 insertions(+)
 create mode 100755 misc/cronjobs/delete_patrons.pl


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list