[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-1215-gf9068d5

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  f9068d5938b2d86d425f703c08b7789c2f1fc613 (commit)
       via  4cb139b9cecf33e10fb2fdc0ea6839dabd683d55 (commit)
       via  3b7c6932e57300b04d0de1288822e7aba58efc59 (commit)
      from  946908403f7119b7b845767f4105732474cc2356 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f9068d5938b2d86d425f703c08b7789c2f1fc613
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Mon Sep 9 11:02:01 2013 -0300

    Bug 9735: Unit tests for get_template_and_user (cookies handling)
    
    Galen found a case where the cookies array was not built flat. I add a
    unit test for that (check the cookie array is flat) and also test the
    cookies output of get_template_and_user so we are sure the &language=
    parameter is correctly handled.
    
    Sponsored-by: Universidad Nacional de Cordoba
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    - Tests in t/db_dependent/Auth.t pass
    - Tested in intranet, OPAC logged in, OPAC logged out
      * Adding a valid language code to the URL switches the language
        as expected
      * Adding an invalid language code causes no change
    
    Nice feature!
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 4cb139b9cecf33e10fb2fdc0ea6839dabd683d55
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Wed Jun 5 14:56:38 2013 -0300

    Bug 9735 - Build the cookie array correctly
    
    The current implementation didn't build the cookie array correctly,
    yielding login problems in some scenarios.
    
    Sponsored-by: Universidad Nacional de Córdoba
    
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 3b7c6932e57300b04d0de1288822e7aba58efc59
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Sat Mar 2 21:25:23 2013 -0300

    Bug 9735 - Let the language be selected through URL parameters
    
    Passing language=<valid_language_code> as a parameter in any Koha's URL
    can be used to set the desired language.
    This patch touches
     - C4::Templates
     - C4::Auth
    
    Adds a new method getlanguagecookie that does exactly that, for use in
    get_template_and_user.
    Also modifies getlanguage so it checks (a) if there's a 'language'
    parameter in the CGI object and (b) checks if its valid and enabled for
    the desired interface.
    
    To test:
    * Without the patch
      - access any koha page
      - add ?language=code to the end of the URL (change code for a valid language code
        it needs to be installed using perl translate install code, and enabled either for
        the staff or opac interface, depending where are you testing)
      - Nothing happens with the language parameter
    * With the patch
      - access any koha page
      - add ?language=code (the same as before) and hit enter
      - the language should be changed to the one you chose
      - if you browse through some links, you will see
        koha 'remembers' the language you passed as a parameter
        (i.e. the language cookie has been updated).
    
    Sponsored-by: Universidad Nacional de Córdoba
    Signed-off-by: Brendan <brendan at bywatersolutions.com>
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    
    Comment: Works very well. No errors.
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.
    More comments on last patch.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth.pm            |   33 +++++++++++++---
 C4/Templates.pm       |   34 ++++++++++++++++-
 t/db_dependent/Auth.t |  100 +++++++++++++++++++++++++++++++++++++++++++++++--
 3 files changed, 157 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
main Koha release repository