[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-1225-g117f8a5

Git repo owner gitmaster at git.koha-community.org
Fri Oct 4 17:47:43 CEST 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  117f8a5ccc592631396ceacbf13d208528f59f51 (commit)
       via  ff7b4d4aa328ffafe58f71a0ec44d998a1a325a2 (commit)
       via  84494966d44d659dcb10e6403bc43945e4a32eab (commit)
       via  5c0fa5ec3da4d1aa9665e1d7db00581df6a263fb (commit)
      from  b26af80f81e1f7b6543f32ba212c447c5207c5c1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 117f8a5ccc592631396ceacbf13d208528f59f51
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Fri Sep 27 11:48:01 2013 +0200

    Bug 10856: Fix cover display in shelf browser
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    I was able to reproduce the problem with local covers and
    the patch fixes it in my tests.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit ff7b4d4aa328ffafe58f71a0ec44d998a1a325a2
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Sep 17 08:33:01 2013 -0400

    Bug 10856: (Follow-up) improve behavior of the "close shelf browser" link
    
    In Firefox at least, the shelf browser cannot be reopened after
    hiding it with the "close shelf browser" link. This followup improves
    the behavior of the "close shelf browser" link so that the shelf browser
    can be redisplayed.
    
    To test, open a bibliographic detail page in the OPAC and click a
    "browse shelf" link. Click the "close shelf browser" link--the shelf
    browser should be hidden. Click the original "browse shelf" link and the
    shelf browser should reappear without reloading the page.
    
    Test with Firefox and Chrome (at least).
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    All tests and QA script pass.
    
    Testing notes:
    - New unit tests in t/db_dependent/ShelfBrowser.t pass.
    - System preference  OPACShelfBrowser still works as expected.
    - Closing and opening the shelf browser works as expected.
    - Next and Previous links show new and nicer behaviour.
    - Logs are clean.
    
    Tested with Firefox and Chromium under Ubuntu.
    
    Notes: The currently displayed record could maybe be highlighted
    a bit better.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 84494966d44d659dcb10e6403bc43945e4a32eab
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Fri Sep 13 09:55:51 2013 +0200

    Bug 10856: (follow-up) if callnumbers are equal, order should be on itemnumber
    
    If a lot of items has the same callnumber, the order should be on the
    itemnumbers. Otherwise the left side is always filled with the same
    items.
    
    + Fix a bad c/p for the next link (when js is disabled).
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 5c0fa5ec3da4d1aa9665e1d7db00581df6a263fb
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Tue May 14 15:11:11 2013 +0200

    Bug 10856: Improve the previous and next items on the shelf browser
    
    The next and previous links should completely refresh the shelf.
    
    For example:
    [<] [1] [2] [3] [4] [5] [6] [>]
    Before this patch, the next and previous links were the same as the 1
    and 6.
    With this patch, after clicking on next, we will get:
    [<] [7] [8] [9] [10] [11] [12] [13] [>]
    
    This patch adds a new AJAX script to get the shelf browser block.
    
    Test plan:
    - On a detail biblio page, click on a "Browse shelf" link.
    - Play with the next and previous links.
    - Deactivate Javascript (using NoScript for example) and check that you
      get the same behavior (but the page is reloaded).
    - Launch the unit tests: prove t/db_dependent/ShelfBrowser.t
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/ShelfBrowser.pm                                 |  131 ++++++------
 .../opac-tmpl/prog/en/includes/shelfbrowser.inc    |  143 +++++++++++++
 koha-tmpl/opac-tmpl/prog/en/js/google-jackets.js   |    4 +-
 koha-tmpl/opac-tmpl/prog/en/js/localcovers.js      |    4 +-
 koha-tmpl/opac-tmpl/prog/en/js/openlibrary.js      |    2 +-
 koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt |  150 ++------------
 .../opac-tmpl/prog/en/modules/svc/shelfbrowser.tt  |    2 +
 opac/opac-detail.pl                                |   13 +-
 opac/svc/shelfbrowser.pl                           |   41 ++++
 t/db_dependent/ShelfBrowser.t                      |  212 ++++++++++++++++++++
 10 files changed, 491 insertions(+), 211 deletions(-)
 create mode 100644 koha-tmpl/opac-tmpl/prog/en/includes/shelfbrowser.inc
 create mode 100644 koha-tmpl/opac-tmpl/prog/en/modules/svc/shelfbrowser.tt
 create mode 100755 opac/svc/shelfbrowser.pl
 create mode 100644 t/db_dependent/ShelfBrowser.t


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list