[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-1241-gb8dbff0

Wed Oct 9 05:43:20 CEST 2013

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  b8dbff02830429c511d860782e956e579be4bec4 (commit)
       via  5b74a81e3d1dcb3e8a351126503605baa20241a8 (commit)
       via  175cdb44f953044878194e3a0fb9193e0142db10 (commit)
       via  b6909640eff08c4ba946b50b46d8d561385321ff (commit)
       via  924c4f69e07ca2072900187cfd082299964a4ad6 (commit)
       via  24984fcb7bff7bc6c618d794aca6c63fd831bbab (commit)
       via  c93e5b12f89507f317b202208a765dba4f555425 (commit)
       via  e738f991b0f04003e95e80842c76c547b112b246 (commit)
       via  3b56392a6f99577c69c5636f52be7c51ddbbec73 (commit)
       via  b6577d13af2319f03b98ff19ac1d17773f55bff8 (commit)
      from  547c6d29499a3e1306a27050b407560a1c4f8fb6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b8dbff02830429c511d860782e956e579be4bec4
Author: Kenza Zaki <kenza.zaki at biblibre.com>
Date:   Wed Aug 28 10:46:07 2013 +0200

    Bug 10795: Improvements for GetOpenIssue in C4::Circulation

    This patch adds some improvements for the routine GetOpenIssue().
    Now, it verifies if the parameter is given (if not it returns undef)
    and it returns $sth->fetchrow_hashref() instead of a $issue.

    To test:
    prove t/db_dependent/Circulation_issue.t
    t/db_dependent/Circulation_issue.t .. ok
    All tests successful.
    Files=1, Tests=16,  2 wallclock secs ( 0.06 usr  0.01 sys +  1.09 cusr  0.07 csys =  1.23 CPU)
    Result: PASS

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

    Comment: Same situation as the one noted in comment of
    Bug 10683, test fails unless there is an issuingrule
    All, All with 1 as renewals allowed.

    With that condition, it succeeds

    No koha-qa errors

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 5b74a81e3d1dcb3e8a351126503605baa20241a8
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Thu Sep 19 16:20:28 2013 +0200

    Bug 10683: (follow-up) improvements to the unit tests

    The borrowers table needs to be cleared after the items table
    (last_returned_by column).

    Some checks were missing for GetRenewCount and AddRenewal.

    Now the tests simulated a renewal for a item and check that the renews
    left is decremented.

    Moreover the issuingrules tables should be cleared and filled with known
    values.

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 175cdb44f953044878194e3a0fb9193e0142db10
Author: Kenza Zaki <kenza.zaki at biblibre.com>
Date:   Wed Aug 28 10:08:10 2013 +0200

    Bug 10683: add unit tests for CRUD routines in C4::Circulation

    This patch adds some unit tests wrapped in a transaction for
    C4::Circulation.pm.

    Circulation_Branch.t adds tests for routines which deal with
    branch_item_rules,branch_borrower_circ_rules,
    default_branch_circ_rules, default_circ_rules, and
     default_branch_item_rules in the database.

    Circulation_issue.t adds tests for routines which deal with accountline
    and issues in the database.

    NOTE: Some commented tests have to be fixed, and some tests can be added.
    More, other routines of Circulation.pm are tested in the patches:

    10692	UT: Routines about transfers in Circulation.pm need unit tests
    10710	UT : OfflineOperation's routines in C4/Circulation.t need unit tests
    10767   UT: Routines which interact with the table issuingrules in C4/Circulation need unit test

    Test plan:
    prove t/db_dependent/Circulation_issue.t
    t/db_dependent/Circulation_issue.t .. ok
    All tests successful.
    Files=1, Tests=16,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.40 cusr  0.02 csys =  0.44 CPU)
    Result: PASS

    prove t/db_dependent/Circulation_Branch.t
    t/db_dependent/Circulation_Branch.t .. ok
    All tests successful.
    Files=1, Tests=10,  2 wallclock secs ( 0.06 usr  0.00 sys +  1.02 cusr  0.06 csys =  1.14 CPU)
    Result: PASS

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

    Comment: Well, I don't know exactly what to do with this, so
    I left it to QA

    a) prove t/db_dependent/Circulation_Branch.t works well and without erros

    b) prove t/db_dependent/Circulation_issue.t works without errors for me
    ONLY if I have a issuingrule for All, All with 1 as renewals allowed, in
    other cases it fails.

    No koha-qa errors

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit b6909640eff08c4ba946b50b46d8d561385321ff
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Wed Oct 9 03:48:02 2013 +0000

    Bug 10698: (follow-up) remove now-superfluous FIXME comment

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 924c4f69e07ca2072900187cfd082299964a4ad6
Author: Kenza Zaki <kenza.zaki at biblibre.com>
Date:   Thu Aug 8 10:39:26 2013 +0200

    Bug 10698: give C4::Circulation::DeleteTransfer() a return value

    This patch adds return values to DeleteTransfer:
    Undef if no parameters are given
    1 if a Transfer is deleted
    0E0 if a wrong parameter is given

    It also fixes some unit tests in t/db_dependent/Circulation_transfers.t

    To test:
    prove t/db_dependent/Circulation_transfers.t
    t/db_dependent/Circulation_transfers.t .. ok
    All tests successful.
    Files=1, Tests=14, 20 wallclock secs ( 0.03 usr  0.00 sys +  0.39 cusr  0.02 csys =  0.44 CPU)
    Result: PASS

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Comment: Applied 10681 and 10692 before 10698
    Run prove t/db_dependent/Circulation_transfers.t without errors
    No koha-qa errors on all 3 patches

    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 24984fcb7bff7bc6c618d794aca6c63fd831bbab
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date:   Sun Aug 25 19:53:29 2013 -0300

    Bug 10711: (follow-up) removing tabs

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit c93e5b12f89507f317b202208a765dba4f555425
Author: Kenza Zaki <kenza.zaki at biblibre.com>
Date:   Mon Aug 12 14:40:50 2013 +0200

    Bug 10711: make GetOfflineOperation() return $sth->fetchrow_hashref instead of $result

    To test :
    prove t/db_dependent/Circulation_OfflineOperation.t
    t/db_dependent/Circulation_OfflineOperation.t .. ok
    All tests successful.
    Files=1, Tests=7, 19 wallclock secs ( 0.02 usr  0.01 sys +  0.24 cusr  0.02 csys =  0.29 CPU)
    Result: PASS

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Comment: applied 10681 and 10710 before 10711
    prove t/db_dependent/Circulation_OfflineOperation.t run without errors
    koha-qa reports only 2 tabulations, fixed in a follow-up

    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit e738f991b0f04003e95e80842c76c547b112b246
Author: Kenza Zaki <kenza.zaki at biblibre.com>
Date:   Mon Aug 5 11:28:03 2013 +0200

    Bug 10681: remove inappropriate uses of finish() from C4::Circulation

    This patch gets rid of finish().

    From the man page

    finish()
    Indicate that no more data will be fetched from this statement handle
    before it is either executed again or destroyed.
    You almost certainly do not need to call this method.

    Adding calls to "finish" after loop that fetches all rows is a common
    mistake, don't do it, it can mask genuine problems like uncaught fetch errors.

    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 3b56392a6f99577c69c5636f52be7c51ddbbec73
Author: Kenza Zaki <kenza.zaki at biblibre.com>
Date:   Mon Aug 5 11:50:40 2013 +0200

    Bug 10682: remove inappropriate uses of finish() from C4::Reserves

    This patch gets rid of finish.

    From the man page

    finish()
    Indicate that no more data will be fetched from this statement handle
    before it is either executed again or destroyed.
    You almost certainly do not need to call this method.

    Adding calls to "finish" after loop that fetches all rows is a common
    mistake, don't do it, it can mask genuine problems like uncaught fetch errors.

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Comment: Similar to other patches from the same author
    I run prove t/db_dependent/Reserves.t without errors
    don't know if more tests are needed.
    No koha-qa errors

    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit b6577d13af2319f03b98ff19ac1d17773f55bff8
Author: Kenza Zaki <kenza.zaki at biblibre.com>
Date:   Mon Aug 5 15:55:40 2013 +0200

    Bug 10685: remove inappropriate uses of finish in C4::Accounts.pm

    This patch gets rid of finish.

    From the man page

    finish()
    Indicate that no more data will be fetched from this statement handle
    before it is either executed again or destroyed.
    You almost certainly do not need to call this method.

    Adding calls to "finish" after loop that fetches all rows is a common
    mistake, don't do it, it can mask genuine problems like uncaught fetch errors.

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Comment: Similar to other patches from the same author.
    Run prove t/db_dependent/Accounts.t without errors
    No koha-qa errors

    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Accounts.pm                         |   15 --
 C4/Circulation.pm                      |   35 +---
 C4/Reserves.pm                         |   11 --
 t/db_dependent/Circulation_Branch.t    |  242 +++++++++++++++++++++++
 t/db_dependent/Circulation_issue.t     |  337 ++++++++++++++++++++++++++++++++
 t/db_dependent/Circulation_transfers.t |    7 +-
 6 files changed, 591 insertions(+), 56 deletions(-)
 create mode 100644 t/db_dependent/Circulation_Branch.t
 create mode 100644 t/db_dependent/Circulation_issue.t

hooks/post-receive
-- 
main Koha release repository