[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-1242-g9620d2d

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  9620d2d249577c460d272d4413119d3f43de33cf (commit)
      from  b8dbff02830429c511d860782e956e579be4bec4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9620d2d249577c460d272d4413119d3f43de33cf
Author: root <root at kenza-VirtualBox>
Date:   Thu Jul 25 10:49:21 2013 +0200

    Bug 10641 - GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences
    
    This patch fixes some incoherences of the routine
    GetBooksellerWithOrders().
    
    Now it considers the field $estimateddeliverydateto and it replaces it
    by now() only if it is undef.
    
    Also, it doesn't test if $aqbookseller.deliverytime is not Null anymore
    but if $deliverytime = null or undef, it replaces it by 0.
    
    It also verifies if $delay is >= 0 and return undef if it is a negative
    value.
    
    To Test:
    Before, this routine sorts out the BookSellerWithLateOrders. If a
    bookseller did not specify a deliverytime, it would never appears in
    the list of LateOrders.  Moreover, if the field "Estimated delivery
    date to" was specified, it didn't take care of the value and it
    returns the late order up to today's date.
    
    Now, the returned list considers all the fields give and if the
    delivery time of the bookseller is not specified, it calculates the
    late orders as if the deliverytime is 0.  By default, all booksellers
    which have orders in late until today are listed unless "estimated
    delivery date to" is specified.
    
    prove t/db_dependent/Bookseller.t
    t/db_dependent/Bookseller.t ..
    [Some warnings about uninitialized values]
    WARNING: GetBooksellerWithLateOrders is called with a negative value at C4/Bookseller.pm line 135.
    t/db_dependent/Bookseller.t .. ok
    All tests successful.
    
    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    All tests and QA script pass.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Bookseller.pm            |   32 +++++++++++++++-----------
 t/db_dependent/Bookseller.t |   53 ++++++++++++++++++-------------------------
 2 files changed, 41 insertions(+), 44 deletions(-)


hooks/post-receive
-- 
main Koha release repository