[koha-commits] main Koha release repository branch master updated. v3.14.00-alpha1-15-ga9b5646

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  a9b564678e184b44b4c54d72e21f66efc3810f4e (commit)
      from  5fe524cf3ab0ff78401e7b467823da4d62d9a537 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a9b564678e184b44b4c54d72e21f66efc3810f4e
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Mon Sep 9 14:12:05 2013 +0200

    Bug 10843: fix crash that can occur when confirming hold if ReservesMaxPickUpDelay is undefined
    
    Test plan:
    1) set an empty string for the ReservesMaxPickUpDelay pref
    2) place a hold on an item
    3) check in the item
    4) click on "Print and confirm"
    5) an error occurs
    > The 'days' parameter (undef) to DateTime::Duration::new was an 'undef'
    6) apply the patch
    7) repeat steps 1 to 4
    8) the error does not occur anymore.
    
    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    An empty string didn't do it for me, I had to set the
    variable for the systempreference to NULL. I am not sure
    if this can happen when editing from the interface, but
    this change should not have any ill side effects and it has
    unit tests!
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Letters.pm |    2 +-
 t/Letters.t   |   18 ++++++++++++++----
 2 files changed, 15 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
main Koha release repository