[koha-commits] main Koha release repository branch master updated. v3.14.00-alpha2-52-g06ea76c
Git repo owner
gitmaster at git.koha-community.org
Wed Oct 30 04:07:34 CET 2013
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 06ea76c3c2c9afcc324166c12b0510fdad0d77f1 (commit)
via e74b91165de888cd260afd575c20358dc9f435d7 (commit)
via 78d27ad5393308ce097db9aa0dfe5c28aa40a516 (commit)
from cec91b4a2c32bb620b8db35728fd3c1079485162 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 06ea76c3c2c9afcc324166c12b0510fdad0d77f1
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Oct 9 14:02:23 2013 -0400
Bug 10243: (follow-up) prevent TransportCostMatrix from overriding library holds policy
Using the TransportCostMatrix can cause the same issue. Removing the
last ditch use of the first item causes the the subroutine to continue
with the traditional matching, which will respect the hold policies.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit e74b91165de888cd260afd575c20358dc9f435d7
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Sep 16 11:31:22 2013 -0400
Bug 10243: (follow-up) add unit tests
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 78d27ad5393308ce097db9aa0dfe5c28aa40a516
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue May 14 14:59:07 2013 -0500
Bug 10243: prevent holds queue from making transfer requests that contradict library holds policy
For some reason MapItemsToHoldRequests will, as a last ditch effort,
grab what seems to be an arbitrary available item to fill a hold request,
even if it will violate the circulation rules for holds.
In other words, even if an item matches a "Holds policy by item type"
that says "From home library", a request to transfer that item to
another library will be added to the holds queue!
Test Plan:
1) Create a record with a an item at BranchA of item type BOOK
2) Set the holds policy such that itemtype BOOK for BranchA is set
to "From home library"
3) Place a bib-level hold request for a patron with a pickup at BranchB
4) Run build_holds_queue.pl
5) You should now see a request for that item to be transfered to
BranchB, even though the rules should not allow this.
6) Apply this patch
7) Run build_holds_queue.pl again
8) View the holds queue again, that request should no longer exist
Signed-off-by: Heather Braum <hbraum at nekls.org>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
-----------------------------------------------------------------------
Summary of changes:
C4/HoldsQueue.pm | 14 +++--
t/db_dependent/HoldsQueue.t | 145 ++++++++++++++++++++++++++++++++++++++++++-
2 files changed, 154 insertions(+), 5 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list