[koha-commits] main Koha release repository branch master updated. v3.14.00-alpha2-133-gf57a057

Git repo owner gitmaster at git.koha-community.org
Thu Oct 31 18:47:21 CET 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  f57a057ef4420bf5e30ed36a054d99058cdfa4f3 (commit)
      from  c6323e96f391bf82b18a621aa9448f12fec9bc31 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f57a057ef4420bf5e30ed36a054d99058cdfa4f3
Author: David Cook <dcook at prosentient.com.au>
Date:   Mon Sep 30 15:47:03 2013 +1000

    Bug 10974: make OAI-PMH resumption tokens handle time correctly
    
    This patch changes the value separator in OAI-PMH resumption tokens
    from colons to slashes, so that the token string isn't split incorrectly
    when a time is included.
    
    TEST PLAN:
    
    1) Turn on the OAI-PMH server syspref in Koha
    2) Send a ListRecords request using 'from' and 'until' arguments that
    include times (Best to use very far apart times so that you retrieve
    more than 50 records which will likely be the trigger for a resumptionToken).
    Here is an example:
    
    http://KOHAINSTANCE/cgi-bin/koha/oai.pl?verb=ListRecords&
    metadataPrefix=oai_dc&from=2012-09-05T13:44:33Z&until=2014-09-05T13:44:33Z
    
    N.B. Replace KOHAINSTANCE with the URL of your Koha instance.
    
    3) Scroll down to the bottom of the page until you find the resumptionToken.
    It will look similar to this:
    
    <resumptionToken cursor="50">
    oai_dc:50:2012-09-05T13:44:33Z:2014-09-05T13:44:33Z:
    </resumptionToken>
    
    4) Copy that resumption token and send a request with it like so:
    
    http://KOHAINSTANCE/cgi-bin/koha/oai.pl?verb=ListRecords&
    resumptionToken=oai_dc:50:2012-09-05T13:44:33Z:2014-09-05T13:44:33Z:
    
    5) The page should (incorrectly) show no records.
    
    6) APPLY PATCH
    
    7) Repeat steps 2, 3, and 4
    
    8) Note that the resumptionToken now uses slashes (e.g. /) instead of
    colons.
    
    Note also that now the second request will show records!!!
    
    N.B. This will only happen if Koha has enough records to serve to you.
    If your Koha has less than 50 records, try lowering the number provided
    in the "OAI-PMH:MaxCount" system preference.
    
    Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros at gmail.com>
    
    I understand; I can now confirm the behaviour described in the test plan.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes test plan, all tests and QA script.
    Resumption Token works correctly after applying the patch.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 opac/oai.pl |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list