[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-1022-g600e953

Git repo owner gitmaster at git.koha-community.org
Wed Sep 4 19:02:30 CEST 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  600e953dff44c29fe7a2996fbacbd8e57cd7eb35 (commit)
      from  d1f8d8811b1d2d96f1b087edf42f395c89c8df0f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 600e953dff44c29fe7a2996fbacbd8e57cd7eb35
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Mon Jul 15 12:14:53 2013 +0200

    Bug 10588: improve selection of default branch for OPAC popular items pag
    
    In OPAC most popular items page:
    With user is logged-in his branch should be selected by default.
    When a branch is manually selected and form is submitted, this branch
    should be selected in results page.
    When looking at HTML, you see that all options are selected in combobox.
    
    This patch corrects by using the hidden input 'do_it' to distinguish
    form display and no branch filter selected.
    
    Test plan :
    - Make sure there are issues on records created in the past 3 month
    - Go to OPAC not logged-in
    - Click on "Most popular"
    => You get to page with results, "All libraries" is selected
    - Select a branch and submit
    => You get to page with results, the branch is selected [testing opac-topissues.inc from]
    - Select a branch and perform a search that does not have results (for example an item type never issued)
    => You get to page without results, the branch is selected [testing opac-topissues.tt form]
    - Log-in with a user
    - Click on "Most popular"
    => You get to page with results, user's branch is selected
    - Select "All libraries" and submit
    => You get to page with results, "All libraries" is selected [testing opac-topissues.inc from]
    - Select "All libraries" and perform a search that does not have results (for example an item type never issued)
    => You get to page without results, "All libraries" is selected [testing opac-topissues.tt form]
    
    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Works nicely and passes all tests.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 .../opac-tmpl/prog/en/includes/opac-topissues.inc  |    2 +-
 opac/opac-topissues.pl                             |    6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list